fix: Use autovideoconvert for GPU-accelerated color conversion #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces videoconvert with autovideoconvert in video processing blocks to enable GPU-accelerated color conversion when available. This fixes hardware encoder compatibility issues where software videoconvert couldn't keep up with the pipeline. Fixes #188 - H.265 HEVC hardware encoding now works correctly. Updated blocks: - videoenc: Video encoder block (primary fix for issue #188) - videoformat: Video format conversion block - decklink: DeckLink video input/output blocks - ndi: NDI video input/output blocks autovideoconvert automatically selects the best converter: - glcolorconvert for OpenGL pipelines - CUDA converters for NVIDIA hardware - Falls back to software videoconvert when needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
srperens
force-pushed
the
fix/autovideoconvert-hardware-encoding
branch
from
ffe79ac to
f45f7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
videoconvertwithautovideoconvertin video processing blocksFixes #188
Problem
The
videoconvertelement is software-only and can't keep up with hardware encoding pipelines. When using H.265 hardware encoding with Decklink input, the pipeline failed with:Solution
autovideoconvertautomatically selects the best available converter:glcolorconvertfor OpenGL pipelinesvideoconvertwhen neededUpdated Blocks
videoenc.rsvideoformat.rsdecklink.rsndi.rsNote: Compositor block intentionally kept with
videoconvertfor CPU-based compositing.Test plan
🤖 Generated with Claude Code