Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I came across some flac files that were shipped inside mp4 containers. Since mp4ff has no support for those, I tried to add them myself.
Resources I used:
ID3v2 support is minimal. The idea is that if someone wants to parse it fully, they should use an ID3v2 parser. I thought a complete implementation here would be out of scope and fairly complex. For my use-case it's perfectly enough if I can just extract the raw data.
I am not too familiar with the project internals yet so I am sure there are some parts that could be improved. For that reason I allowed the edits by maintainers and feel free to refactor anything you come across.