Add "Sound Codes" #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a1d595.
Owner
|
Cool stuff, I'll look into reviewing & merging this very soon! :-) |
This comment has been minimized.
This comment has been minimized.
Owner
|
Hey, my apologies for the long delay. Unfortunately, these changes are now outdated, but I believe #155 is the perfect successor to this Pull Request, minus the sharing feature. I'm closing this Pull Request, but if anyone is interested in re-implementing a similar sharing feature to the one in this Pull Request that works with #155, feel free to submit your code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for users to create a "sound code" by simply typing the normal keyboard buttons into a text area and then setting the time between notes. This code can then be shared with other users or converted into a URL by putting ?p&c=INSERT CODE HERE&t=INSERT TIMING HERE.