chore: Update fishing regulations and penalties #16
Conversation
WalkthroughThe penal code file was modified to update three fishing statutes: statute 10008 had "Zancudo River" removed from prohibited grounds; statute 10009 was reclassified from Misdemeanor to Infraction with weight-based penalties and reduced sentences; statute 10010's description and penalties were updated to reflect weight-based monitoring and enforcement. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
penal-code.ts (2)
1519-1521: Consider externalizing the species list for better maintainability.The prohibited fish species list with rarity tiers (Barreleye, Oarfish, Whale Shark, Arapaima, Giant Snakehead) is hardcoded directly in the statute description. If these species or classifications change, the statute text will need to be modified.
Consider maintaining the species list in a separate configuration or reference document that can be updated independently, with the statute simply referencing "species designated as prohibited by BCSO Wildlife: Fish & Game regulations."
1527-1528: Consider removing hardcoded fine amount from description.The description explicitly states "up to $600" while the
finefield is also set to 600. This duplication could lead to maintenance issues if the fine amount is changed in the future and only one location is updated.Consider revising the description to reference "as defined in this statute" or simply "punishable under this code section" instead of specifying the dollar amount.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
penal-code.ts(1 hunks)
🔇 Additional comments (1)
penal-code.ts (1)
1511-1511: LGTM! Prohibited fishing zone list updated correctly.The removal of "Zancudo River" from the prohibited fishing grounds is clear and the remaining restricted areas are properly listed.
| description: | ||
| "Illegal fishing is defined as fishing using illegal hooks or possessing, transporting, or selling fish of prohibited weights or species. The following species are strictly prohibited from possession under any circumstances and may only be caught for sport and must be immediately released upon capture: Barreleye (Legendary), Oarfish (Epic), Whale Shark (Epic), Arapaima (Rare), Giant Snakehead (Rare). All other fish species may be caught, transported, or sold only within their legal weight limits as officially posted by BCSO Wildlife: Fish & Game. Any fish below the minimum or above the maximum listed weight is considered illegal and subject to confiscation and penalty as defined above per violation.", | ||
| }, |
There was a problem hiding this comment.
Clarify external reference to weight limits.
The description references "legal weight limits as officially posted by BCSO Wildlife: Fish & Game" without specifying where these limits are published or how they can be accessed. This creates ambiguity in enforcement, as the statute's applicability depends on external documentation that may not be readily available to those subject to the law.
Consider either:
- Including the weight limits directly in the statute description
- Adding a specific reference (e.g., "as defined in Section X" or "available at [specific location/URL]")
- Referencing a separate regulations document that's maintained alongside the penal code
🤖 Prompt for AI Agents
In penal-code.ts around lines 1519 to 1521, the description references "legal
weight limits as officially posted by BCSO Wildlife: Fish & Game" without a
specific source, which creates ambiguity; update the text to either include the
relevant weight limits directly, or add a precise citation to where they are
published (e.g., a section number, title of the regulations document, or a
stable URL) or reference a companion regulations document maintained with the
code; ensure the chosen approach is consistently worded (e.g., "as defined in
Section X of the BCSO Wildlife Regulations" or "available at https://...") so
enforcement and readers can unambiguously locate the limits.
Clarify what constitutes "per violation."
The description ends with "per violation" but doesn't clearly define the scope of a single violation. Is it per fish, per fishing trip, per species, or per prohibited activity? This ambiguity could lead to inconsistent enforcement.
🤖 Prompt for AI Agents
In penal-code.ts around lines 1519 to 1521, the phrase "per violation" is
ambiguous; update the description to explicitly define what constitutes a single
violation (for example: "each individual fish", "each species per incident", or
"per fishing trip/transport event") and state which metric applies to prohibited
weight/species infractions and to possession/transport/sale violations; revise
the sentence to name the chosen unit(s) (e.g., "Each illegally possessed fish
constitutes one violation" or "Each distinct incident/transport constitutes one
violation") so enforcement and penalties are unambiguous.
1 participant
Summary by CodeRabbit