improve tests #24
Open
improve tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make adding tests easier. Also added test for node-archiver, which jqueryui uses.
Author
|
I updated the tests with jQueryUI's custom zip and bootstrap's zip, two that we've had problems with specifically with Bower. This fails on 0.10.3 and 0.8.22 removing the jQueryUI one causes the tests to hang on extracting bootstrap.zip. Hopefully this helps in diagnosing and testing what is wrong :/ no jQueryUI test on 0.8.22: no jQueryUI test on 0.10.3 |
|
Bump! |
|
bump |
|
@nearinfinity can you review this PR soon? It's blocking us pretty hard. :/ |
|
bump! |
|
@nearinfinity can you try to merge this soon and bump the package. thank you! |
|
Yes plz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed compressed.js to run all the tests for every compressed* folder in the testData directory to a) simplify the tests and b) make it easier to add more archives to test