Skip to content

Conversation

@turkot
Copy link
Contributor

@turkot turkot commented Dec 18, 2025

I've been writing a section on detector masks in the DA user's documentation and realized it would be useful to have a code example on how to read the mask from our processed data files.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@turkot turkot requested a review from takluyver December 18, 2025 15:36
@turkot turkot self-assigned this Dec 18, 2025
@turkot turkot added the documentation Improvements or additions to documentation label Dec 18, 2025
@takluyver
Copy link
Member

Thanks!

I agree it makes more sense now to illustrate loading real data, even if that means the notebook needs to be run on Maxwell. But if we're doing that, I think we can replace the previous example (based on empty mock data) with the real one, rather than adding a new example to the notebook.

Passing data='proc' to open_run() is no longer the best way to get corrected data. open_run() should now expose both raw & corrected data, and LPD1M() should prefer corrected data by default. This depends on the renaming of corrected detector sources, though - I'll rerun correction on this data so we can illustrate how things work now rather than how they worked 2 years ago.

Finally, I think we're confident enough in these tools now to show people the higher-level way of doing things (e.g. lpd.masked_data()) first, and then break out the lower-level pieces for people who need them. We could even pull in EXtra-geom and show some data as images, rather than numbers in arrays - but up to you, the numbers do make it clearer what's going on with NaNs.

@takluyver
Copy link
Member

Recalibrating r117 succeeded, so LPD1M(open_run(...)) should now find corrected data by default. Pass LPD1M(..., raw=True) to look at raw data. You can also use raw=False to ensure it looks at corrected data, rather than falling back to raw if no corrected data is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants