StructArrays extension #1966
Open
StructArrays extension #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
approved these changes
Dec 12, 2025
avik-pal
reviewed
Dec 12, 2025
| @safetestset "OneHotArrays" include("integration/onehotarrays.jl") | ||
| @safetestset "AbstractFFTs" include("integration/fft.jl") | ||
| @safetestset "SpecialFunctions" include("integration/special_functions.jl") | ||
| @safetestset "StructArrays" include("integration/structarrays.jl") |
Collaborator
There was a problem hiding this comment.
missing a test dependency on structarrays
avik-pal
reviewed
Dec 12, 2025
| idx = idx_ref[] + 1 | ||
|
|
||
| scalar_args = [@allowscalar(arg[idx]) for arg in args] | ||
| scalar_args = [@allowscalar((@inbounds arg[idx])) for arg in args] |
Collaborator
There was a problem hiding this comment.
is there a specific reason we need inbounds?
Collaborator
Author
There was a problem hiding this comment.
Without, I run into:
ERROR: ArgumentError: unable to check bounds for indices of type Reactant.TracedRNumber{Int64}
Stacktrace:
[1] checkindex(::Type{Bool}, inds::Base.OneTo{Int64}, i::Reactant.TracedRNumber{Int64})
@ Base ./abstractarray.jl:751
[2] checkbounds
@ ./abstractarray.jl:689 [inlined]
[3] checkbounds
@ ./abstractarray.jl:699 [inlined]
[4] _getindex
@ ~/Reactant2/ext/ReactantStructArraysExt.jl:62 [inlined]
[5] getindex
@ ~/comrade-reactant/StructArrays.jl/src/structarray.jl:345 [inlined]
[6] #26
@ ~/.julia/packages/GPUArraysCore/aNaXo/src/GPUArraysCore.jl:206 [inlined]
[7] (::Reactant.TracedUtils.var"#26#28"{…})(arg::StructVector{…})
@ Reactant.TracedUtils ./none:0
[8] iterate
@ ./generator.jl:48 [inlined]
[9] collect
@ ./array.jl:791 [inlined]
[10] (::Nothing)(none::typeof(collect), none::Base.Generator{Vector{…}, Reactant.TracedUtils.var"#26#28"{…}})
@ Reactant ./<missing>:0
[11] call_with_reactant(::typeof(collect), ::Base.Generator{Vector{…}, Reactant.TracedUtils.var"#26#28"{…}})
@ Reactant ~/Reactant2/src/utils.jl:523
[12] __elem_apply_loop_body
@ ~/Reactant2/src/TracedUtils.jl:1101 [inlined]
[13] (::Nothing)(none::typeof(Reactant.TracedUtils.__elem_apply_loop_body), none::Base.RefValue{…}, none::Base.RefValue{…}, none::Base.RefValue{…}, none::Base.RefValue{…}, none::Base.RefValue{…})
@ Reactant ./<missing>:0
[14] getproperty
@ ./Base.jl:49 [inlined]
[15] getindex
@ ./refvalue.jl:59 [inlined]
[16] __elem_apply_loop_body
@ ~/Reactant2/src/TracedUtils.jl:1095 [inlined]
But that probably just means I need to add
checkindex(::Type{Bool, inds, i::TracedRNumber{<:Integer})
Though now I'm confused as to why we're not hitting this in other places?
jumerckx
force-pushed
the
jm/structarrays
branch
from
a290b7b to
c23680c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now I've only looked at StructArrays of NamedTuples, as this is what Comrade uses, and what would be useful if we start using StructArrays in Reactant itself.