Gate#getBlockBase now uses the nearest matching block #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
requested changes
Dec 26, 2025
Member
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
Thanks for this!
Have you done any testing to assess how this performs to the old method? A simple loop was chosen here for speed, as some servers have tens of thousands of gates controlled by redstone/etc. My assumption would be that this will have substantially worse cache locality / predictions, but will likely find the gate block earlier than the previous one for most cases.
| import org.enginehub.craftbook.util.EventUtil; | ||
| import org.enginehub.craftbook.util.ProtectionUtil; | ||
| import org.enginehub.craftbook.util.SignUtil; | ||
| import org.enginehub.craftbook.util.*; |
Member
There was a problem hiding this comment.
Would you be able to please make sure that import style is retained & follows our style guide?
| enumerationLoop: while (!enumerationQueue.isEmpty()) { | ||
| Block currentOrigin = enumerationQueue.poll(); | ||
|
|
||
| if (Math.abs(currentOrigin.getX() - sign.getX()) >= searchRadius) |
Member
There was a problem hiding this comment.
Could you please ensure that the if statements/etc here keep the braces and follow the style guide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've already stated in the CraftBook Discord channel, the Gate mechanic often selects blocks which completely go against the intuition of the user, simply due to its search-algorithm, which doesn't consider distance at all. Expanding radially outwards from the point of the sign to me seems like the only right way of doing it.