Use the "clean" asset housekeeping by default #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dalonsoa
approved these changes
Feb 3, 2025
Collaborator
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
LGTM! Maybe they are numerical instabilities of the solver when having to deal with a bigger matrix with extra zeros?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #644
I've decided it's probably better to start using the "clean" hook for all models, but I've simplified it. See this comment
What I don't understand is why this has any impact on the results. Investment is slightly different, and this has a small impact on commodity prices. The changes are small so not too concerning, but strange that there would be any changes at all