SVG components #145
Open
SVG components #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecdar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atjn
requested changes
Dec 6, 2023
Collaborator
atjn
left a comment
atjn
left a comment
There was a problem hiding this comment.
Generally speaking, there is something weird about the size disparity. The container feels very big and has different sizing compared to its locations.
| d="M {cutOff / 2} {cutOff / | ||
| 2} L {cutOff} 0 L {width} 0 L {width} {cutOff / 2} Z" | ||
| /> | ||
| <text x={cutOff} y={cutOff / 3} font-size="2rem">Hello</text> |
Collaborator
There was a problem hiding this comment.
We can't merge "hello" into main
| ></rect> | ||
| <text x={width - 44} y="34" fill="white" font-size="28px" | ||
| >< ></text | ||
| > |
Collaborator
There was a problem hiding this comment.
The text color should change based on the background, and the text should not overflow its container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a good starting point here is what has left to be done: