-
Notifications
You must be signed in to change notification settings - Fork 10
Linking TechRadar tools to RSQKit #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kennethrioja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .md files are generated by scripts/generate_techradar_markdowns.py (see description here : https://github.com/EVERSE-ResearchSoftware/TechRadar/tree/main/scripts)
So for example, the shared description of pytest comes in fact from data/software-tools/pytest.json
We should amend the python script and json instead of the .md files.
|
|
||
| Application Category (or Categories in case of multi-tier tool): AnalysisCode | ||
|
|
||
| See more about [Software identifiers](https://everse.software/RSQKit/software_identifiers) in RSQKit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see bearer being cited in https://everse.software/RSQKit/software_identifiers – why did you point to this RSQKit page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed I missed that
|
|
||
| Application Category (or Categories in case of multi-tier tool): PrototypeTool, ResearchInfrastructureSoftware | ||
|
|
||
| See more about [Writing readable code](https://everse.software/RSQKit/testing_software) or the [Research Software Story - BALER](https://everse.software/RSQKit/baler_research_software_story) in RSQKit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see black in https://everse.software/RSQKit/testing_software
However I can find it here : https://everse.software/RSQKit/writing_readable_code
OK for BALER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think I got the links wrong
|
You can add at the bottom of for each tool's .json file the following (below is the example for I will submit a new PR for modifying |
The JSON files must follow the software metadata schema: https://github.com/EVERSE-ResearchSoftware/schemas/tree/main/software/dev I would discourage implementing this two-way relationship, it will be very hard to maintain ! Tools are defined in one place: the techradar repo. |
--> instead of nightly build we can use repository_dispatch to trigger TechRadar builds when RSQKit tasks are modified. |
|
So if I understood well, a way of doing that through the TechRadar CI would be:
|
One might not need to clone the entire RSQKit repo, but yes you got that right 👍 |
|
Hi again! After searching a little bit on this matter, I would like to summarise what I understand (I haven't used
Is this thought correct? @kennethrioja @vuillaut |
Yes indeed. |
|
@kennethrioja @vuillaut I am not sure how to keep this discussion going (there are two different repos involved), so please feel free to adjust and move the discussion in another place more suitable. Below you can find the initial ideas of the workflow actions that might work: RSQKit:name: Produce links to TechRadar
on:
push:
paths:
- "pages/tasks/*"
jobs:
build-and-dispatch:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Generate mapping JSON from RSQKit tasks
id: makejson
run: |
python3 scripts/build_mapping.py > mapping.json # NEED TO CREATE build_mapping.py. Result: mapping.json file locally
- name: Send dispatch event to TechRadar
env:
TOKEN: ${{ secrets.TECHRADAR_DISPATCH_TOKEN }} # NEED TO ADJUST IN ORDER TO BE ABLE TO WRITE IN TECHRADAR
run: |
mapping=$(cat mapping.json | jq -c .)
curl -X POST \
-H "Authorization: token $TOKEN" \
-H "Accept: application/vnd.github+json" \
https://api.gitub.com/repos/EVERSE-ResearchSoftware/TechRadar/dispatches \
-d "{\"event_type\": \"rsqkit_tasks_update\", \"client_payload\": {\"mapping\": $mapping}}"
|
Thanks @npechl Alternatively, for a (maybe?) more global solution, RSQKit could build a database in CI, similar to what I have done for indicators and dimensions: It could be the |
Closes #216.
pytestbearerblack