Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@taokayan
Copy link
Contributor

fix #7378

Change Description

out of bound check for unpacking fc::signed_int and fc::unsigned_int. add test cases

Consensus Changes

N/A

API Changes

N/A

Documentation Additions

N/A

Copy link
Contributor

@b1bart b1bart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit the changes to fc in a PR to that repo so that it can be integrated into the master branch there and then pulled into this submodule.

In addition, please place the new test cases into their own test module, perhaps test_io_raw.cpp and follow the pattern(s) established in the other test modules so that it is logically easier to find test cases related to certain systems.

@NorseGaud
Copy link
Contributor

You'll need to merge in changes from develop too. Looks like you're using older build scripts that don't install c++ properly and allow it to build on our new base images.

@taokayan
Copy link
Contributor Author

Please submit the changes to fc in a PR to that repo so that it can be integrated into the master branch there and then pulled into this submodule.

In addition, please place the new test cases into their own test module, perhaps test_io_raw.cpp and follow the pattern(s) established in the other test modules so that it is logically easier to find test cases related to certain systems.

Sure. Would you check EOSIO/fc#99?

@brianjohnson5972
Copy link
Contributor

@taokayan @b1bart This is so old, I'm presuming that we should start again, rather than keeping this hanging around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants