Skip to content

Conversation

@mortenlokensr
Copy link

  • Adds a public interface for ClientCredentialsCacheDurationStore
  • Uses interface in DI registration and injection into ClientCredentialsTokenManager
  • Can be used to reference and modification in customer client credentials token manager

Copilot AI review requested due to automatic review settings December 12, 2025 13:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public interface IClientCredentialsCacheDurationStore to enable custom implementations of the client credentials cache duration store. The existing internal ClientCredentialsCacheDurationStore now implements this interface, and dependency injection has been updated to use the interface rather than the concrete type.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
IClientCredentialsCacheDurationStore.cs New public interface defining cache duration store contract
ClientCredentialsCacheDurationStore.cs Updated to implement the new public interface
ClientCredentialsTokenManager.cs Updated to depend on interface instead of concrete type
ServiceCollectionExtensions.cs Updated DI registration to register interface mapping
PublicApiVerificationTests.*.verified.txt Updated test baselines to include new public interface

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ntialsCacheDurationStore.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@damianh
Copy link
Member

damianh commented Dec 14, 2025

Is there an issue or discussion somewhere related to this PR?

@mortenlokensr
Copy link
Author

Is there an issue or discussion somewhere related to this PR?

I started a discussion myself:
https://github.com/orgs/DuendeSoftware/discussions/433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants