Skip to content

explicitly set audience in samples #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erwinvandervalk merged 1 commit into from
Dec 12, 2025
Merged

explicitly set audience in samples #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions access-token-management/samples/WebJarJwt/ClientAssertionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ public ClientAssertionService(
var descriptor = new SecurityTokenDescriptor
{
Issuer = config.ClientId.ToString(),
Audience = config.TokenEndpoint.GetLeftPart(UriPartial.Authority),

// Don't use the TokenEndpoint here. Use the Authority as the audience.
// You may expose yourself to a vulnerability, as described in the document below:
// https://openid.net/wp-content/uploads/2025/01/OIDF-Responsible-Disclosure-Notice-on-Security-Vulnerability-for-private_key_jwt.pdf
Audience = "https://demo.duendesoftware.com",
Expires = DateTime.UtcNow.AddMinutes(1),
SigningCredentials = Credential,

Expand Down Expand Up @@ -87,7 +91,11 @@ public async Task<string> SignAuthorizeRequest(OpenIdConnectMessage message,
var descriptor = new SecurityTokenDescriptor
{
Issuer = config.ClientId.ToString(),
Audience = config.TokenEndpoint.GetLeftPart(UriPartial.Authority),

// Don't use the TokenEndpoint here. Use the Authority as the audience.
// You may expose yourself to a vulnerability, as described in the document below:
// https://openid.net/wp-content/uploads/2025/01/OIDF-Responsible-Disclosure-Notice-on-Security-Vulnerability-for-private_key_jwt.pdf
Audience = "https://demo.duendesoftware.com",
Expires = DateTime.UtcNow.AddMinutes(1),
SigningCredentials = Credential,

Expand Down
2 changes: 1 addition & 1 deletion access-token-management/samples/Worker/ClientAssertionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class ClientAssertionService(IOptionsMonitor<ClientCredentialsClient> opt
var descriptor = new SecurityTokenDescriptor
{
Issuer = options1.ClientId?.ToString(),
Audience = options1.TokenEndpoint?.ToString(),
Audience = "https://demo.duendesoftware.com",
Expires = DateTime.UtcNow.AddMinutes(1),
SigningCredentials = Credential,

Expand Down
2 changes: 1 addition & 1 deletion access-token-management/samples/WorkerDI/ClientAssertionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class ClientAssertionService(IOptionsMonitor<ClientCredentialsClient> opt
var descriptor = new SecurityTokenDescriptor
{
Issuer = options1.ClientId!.ToString(),
Audience = options1.TokenEndpoint!.ToString(),
Audience = "https://demo.duendesoftware.com",
Expires = DateTime.UtcNow.AddMinutes(1),
SigningCredentials = Credential,

Expand Down