-
Notifications
You must be signed in to change notification settings - Fork 42
Select Options disalbed rework #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-176/ |
|
I forgot to run clippy.. |
|
What part of the select focus management needs to be different in select vs other components? This PR fixes the issues for select but if we can integrate those fixes into the hook it would be better so it works for the other components |
|
Since I decided to move the focus functions directly into the The options Each option in the options map has a I am not sure how this information could be made available in |
|
There is a variant of the existing focus hook here that only adds the item to the focus state's list if it isn't disabled. I imagine we could do something similar for select? |
|
The |
|
Feel free to make changes to |
This contains a lot of changes and fixes for the Select component to make disabling options properly work (see #169).
focus_prev,focus_last,focus_next,focus_first, etc. functions that are independent of the ones in FocusState. This also means that i removed FocusState from the SelectContext component.I hope this code is up to your standards and the idea is something you are willing to use.