Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Dec 18, 2025

Using the find_device method instead of looking devices up in the map of
devices directly means child devices can be found, eg 'stage.x' could be
a valid device but isn't in the devices map in its own right.

There is still a bit of weirdness as querying /devices/stage.x will return a
DeviceModel with a name of stage-x but querying for stage-x will
fail with a 404.

Relates to #903 and #1137.

Using the find_device method instead of looking devices up in the map of
devices directly means child devices can be found, eg 'stage.x' could be
a valid device but isn't in the devices map in its own right.
@tpoliaw tpoliaw requested a review from a team as a code owner December 18, 2025 12:47
@tpoliaw tpoliaw requested a review from abbiemery December 18, 2025 12:48
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.75%. Comparing base (21daed5) to head (7cd7dda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   94.74%   94.75%           
=======================================
  Files          42       42           
  Lines        2741     2743    +2     
=======================================
+ Hits         2597     2599    +2     
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants