refactor: Add padding to levelname in terminal logs #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it easier to follow logs when the message part is aligned and the level does not affect where the text starts. The colouring method has been refactored at the same time to reduce the duplication around adding styles.
tpoliaw
force-pushed
the
align-terminal-logging
branch
from
a8c3d84 to
3f871e5
Compare
tpoliaw
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 42 42
Lines 2741 2742 +1
=======================================
+ Hits 2597 2598 +1
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it easier to follow logs when the message part is aligned and
the level does not affect where the text starts.
The colouring method has been refactored at the same time to reduce the
duplication around adding styles.