Vector tfidf #31
Vector tfidf #31
Conversation
src/main.cpp
Outdated
| std::make_unique<scoring::BM25>(engine->getDocumentCount(), engine->getAvgDocumentLength()); | ||
| } else if (scoring_choice == "tf-idf") { | ||
| score_func = std::make_unique<scoring::TfIdf>(engine->getDocumentCount()); | ||
| if (algorithm_choice == "vector") { |
There was a problem hiding this comment.
I think that should be `vector-tfidf´, right?
src/test.cpp
Outdated
There was a problem hiding this comment.
Do we want to keep this test file?
| @@ -0,0 +1,263 @@ | |||
| #include "vector_engine.hpp" | |||
| #include "./index/hnsw/hnsw_alg.hpp" | |||
There was a problem hiding this comment.
Use absolute path if possible
| #include <sys/types.h> | ||
| #include <cstdint> | ||
| #include <string> | ||
| #include "../../fts_engine.hpp" |
There was a problem hiding this comment.
Use absolute include path
| #include <vector> | ||
|
|
||
| #include "../../documents/document_iterator.hpp" | ||
| #include "../../fts_engine.hpp" |
There was a problem hiding this comment.
Use absolute include path
src/test.cpp
Outdated
There was a problem hiding this comment.
Why a test file in the src folder? This does belong in the test folder doesn't it?
CMakeLists.txt
Outdated
| src/algorithms/vector/vector_engine_tfidf.hpp | ||
| src/algorithms/vector/vector_engine.hpp | ||
| src/algorithms/vector/index/vector_lib.hpp | ||
| src/algorithms/vector/index/hnsw/hnsw_alg.cpp |
There was a problem hiding this comment.
The .cpp file should not be part of FTS_HEADERS
| } | ||
|
|
||
| if (did % 10000 == 0) { | ||
| std::cout << did << "\n"; |
There was a problem hiding this comment.
For the benchmarking I think it'd make sense to remove all the prints from the build
There was a problem hiding this comment.
I agree. Only if the index was loaded from disk, instead of being built again, a text is printed now.
There was a problem hiding this comment.
Formatting fails for this file
…ing with new DocumentIterator from main though
No description provided.