Iridescent fresnel, bxdfs #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

devshgraphicsprogramming merged 38 commits into master from iridescence_bxdf

Nov 12, 2025

Contributor

keptsecret commented Aug 27, 2025

No description provided.

keptsecret added 10 commits

August 26, 2025 11:50


          initial iridescent fresnel, only single channel ior

4b3224a


          iridescent fresnel does rgb IOR, use in brdf

9c71906


          some bug fixes

0f51306


          replace loop for vector operations in fresnel

f205d4e


          added iridescent btdf

f6daa6f


          added unit tests

09402ea


          merge bxdfs, fix conflicts

a77c337


          latest example

aa0f6e8


          moved colorspace transform mats into struct functions

d2cb193


          some more colorspace utility

33fc955

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/reflection/iridescent.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/colorspace.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/colorspace.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/colorspace/decodeCIEXYZ.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

Base automatically changed from hlsl_bxdfs to master

August 29, 2025 13:04


          merge latest bxdf_fixes, fix conflicts

0f6c7a2

keptsecret changed the base branch from master to bxdf_fixes_cook_torrance

November 3, 2025 04:05

keptsecret added 3 commits

November 3, 2025 11:13


          restore encode/decode matrices

d8b6773


          colorspace specific dominant wavelengths (still missing ACES), use gl…

65239d9

…obal conversion matrices


          update iridescent fresnel to match fresnel concept

9a8b77e

Base automatically changed from bxdf_fixes_cook_torrance to master

November 3, 2025 13:24

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/colorspace.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/transmission/iridescent.hlsl Outdated Show resolved Hide resolved

Member

devshgraphicsprogramming commented Nov 3, 2025

In this PR also resolve all left over comments from #930


          Merge branch 'master' into iridescence_bxdf

702ec8d

keptsecret added 9 commits

November 7, 2025 16:53


          removed redundant weight in interaction

5782a49


          removed duplicate fresnel code, added creation params for iridescent

55471ca


          split out iridescent fresnel vars into base struct

64be771


          renamed private funcs, replace enable_if usage with NBL_FUNC_REQUIRES

8f9a114


          avoid promoting 1d fresnel to 3d just to dot product, added private f…

8a71f40

…unc for that


          init ndf quants, minor cook torrance fixes

dee1b61


          primaries wavelengths for aces colorspaces (not sure they're correct)

cd9b18b


          fixes to angle adder, handle some edge cases

0984c7e


          Merge branch 'master' into iridescence_bxdf

3d7ded6

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/cook_torrance_base.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/cook_torrance_base.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/ndf/beckmann.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/ndf/ggx.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/math/angle_adding.hlsl Outdated Show resolved Hide resolved


          Bugfix sincos_accumulator::create

Also flesh out future optimizations for faster angle adding

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/fresnel.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/cook_torrance_base.hlsl Show resolved Hide resolved

devshgraphicsprogramming reviewed

View reviewed changes

include/nbl/builtin/hlsl/bxdf/base/cook_torrance_base.hlsl Show resolved Hide resolved

devshgraphicsprogramming merged commit 08ad78a into master

19 of 20 checks passed

devshgraphicsprogramming deleted the iridescence_bxdf branch

November 12, 2025 13:52

devshgraphicsprogramming mentioned this pull request

Final BxDF changes, drafts of Spherical Shape Sampling, RWMC and PAth Tracing #966

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet