Skip to content

Conversation

@dxvladislavvolkov
Copy link
Contributor

@dxvladislavvolkov dxvladislavvolkov self-assigned this Dec 12, 2025
@dxvladislavvolkov dxvladislavvolkov added the dependencies Pull requests that update a dependency file label Dec 12, 2025
Copilot AI review requested due to automatic review settings December 12, 2025 12:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Dependabot security alert #65 by removing the deprecated protractor package and upgrading form-data from version 2.3.3 to 2.5.5 to fix a security vulnerability.

Key Changes:

  • Removed protractor from devDependencies (a deprecated E2E testing framework)
  • Added npm overrides section to enforce form-data version ~2.5.4
  • Updated package-lock.json to reflect the form-data upgrade to 2.5.5 and mark protractor-related dependencies as optional/peer

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Removed deprecated protractor dependency and added overrides to enforce secure form-data version
package-lock.json Upgraded form-data to 2.5.5 (security fix), marked all protractor and its transitive dependencies as optional/peer to prevent installation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"typescript": "~5.8.0"
},
"overrides": {
"form-data": "~2.5.4"
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override constraint "~2.5.4" only allows patch version updates (2.5.4 to 2.5.x), but the package-lock.json shows form-data version 2.5.5 is being installed. This works currently because 2.5.5 is within the tilde range, but the constraint should either:

  1. Use the exact version "2.5.5" if that's the specific security-patched version needed
  2. Use "^2.5.4" to allow minor version updates within 2.x if any future 2.5.x or 2.x versions are acceptable
  3. Keep "~2.5.4" if only patch updates to 2.5.x are desired

Since this is a security fix, it would be clearer to specify the exact version or use a more explicit range that matches the actual installed version.

Suggested change
"form-data": "~2.5.4"
"form-data": "2.5.5"

Copilot uses AI. Check for mistakes.
@dxvladislavvolkov dxvladislavvolkov merged commit c25206d into master Dec 12, 2025
10 checks passed
@dxvladislavvolkov dxvladislavvolkov deleted the fix-critical-alerts branch December 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants