WIP: Publish ValidationCallbackData #32153
Open
+167
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR publishes the ValidationCallbackData type as a public, documented type with generic support. The key changes include adding JSDoc documentation to all properties of ValidationCallbackData, making it generic with a TValue type parameter, and updating both AsyncRule and CustomRule types to accept the generic type parameter. The Angular wrapper files have been updated to use the new ValidationCallbackData type instead of inline type definitions.
Key Changes
ValidationCallbackDatatype is now public with full JSDoc documentation and generic type supportAsyncRuleandCustomRuletypes now accept a genericTValueparameter for type-safe value validation- Angular wrapper components updated to import and use
ValidationCallbackDatatype
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Added generics to AsyncRule and CustomRule types, added JSDoc documentation to ValidationCallbackData |
| packages/devextreme/js/common.d.ts | Added generics to AsyncRule and CustomRule types, added JSDoc documentation to ValidationCallbackData, removed inline parameter documentation |
| packages/devextreme-angular/src/ui/validator/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
| packages/devextreme-angular/src/ui/tree-list/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
| packages/devextreme-angular/src/ui/scheduler/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
| packages/devextreme-angular/src/ui/form/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
| packages/devextreme-angular/src/ui/data-grid/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
| packages/devextreme-angular/src/ui/card-view/nested/*.ts | Updated validationCallback signature to use ValidationCallbackData type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.