feat: DVC9059 move core server request logic to new lib #565

jonathannorris · 2023-09-26T21:23:33Z

pull out the common request logic between the JS Cloud Server SDK and NodeJS SDK into its own library.

vercel · 2023-09-26T21:23:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-sdks-next-js	❌ Failed (Inspect)			Oct 24, 2023 8:02pm
js-sdks-web-elements	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 8:02pm
js-sdks-with-provider	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 8:02pm

jonathannorris · 2023-09-26T21:23:48Z

Current dependencies on/for this PR:

main
- PR feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK #560
  - PR feat: DVC-9055 adding Cloudflare Worker example app for new js-cloud-server-sdk #561
    - PR feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564
      - PR feat: DVC9059 move core server request logic to new lib #565 👈
        
        PR feat: setup new EdgeWorker SDK with cloud and local bucketing #566

This comment was auto-generated by Graphite.

jonathannorris · 2023-09-29T18:22:01Z

lib/shared/config-manager/src/request.ts

    )
 }
-
-async function getWithTimeout(


move to common request lib

jonathannorris · 2023-09-29T18:25:30Z

lib/shared/server-request/src/index.ts

+    status: number
+}
+
+const exponentialBackoff: RequestInitWithRetry['retryDelay'] = (attempt) => {


Moved all common request helper functions here used by various server SDKs.

lib/shared/server-request/src/index.ts

jonathannorris changed the title ~~feat: remove core server request logic to new lib~~ feat: DVC9059 move core server request logic to new lib Sep 26, 2023

This was referenced Sep 26, 2023

feat: DVC-9055 extract JS Cloud Bucketing SDK from NodeJS SDK #560

Merged

feat: DVC-9055 adding Cloudflare Worker example app for new js-cloud-server-sdk #561

Merged

jonathannorris mentioned this pull request Sep 26, 2023

feat: DVC-9059 pull out EnvironmentConfigManager to its own library, change nodejs build to define external pacakges #564

Merged

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 21:27 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 26, 2023 21:32 View deployment

vercel bot deployed to Preview – js-sdks-web-elements September 26, 2023 21:35 View deployment

jonathannorris requested review from a team and ajwootto September 26, 2023 21:35

jonathannorris marked this pull request as ready for review September 26, 2023 21:35

gitstream-cm bot added the 10 min review label Sep 26, 2023

vercel bot deployed to Preview – js-sdks-next-js September 26, 2023 21:38 View deployment

jonathannorris mentioned this pull request Sep 27, 2023

feat: setup new EdgeWorker SDK with cloud and local bucketing #566

Draft

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from ed1fb2d to d811b17 Compare September 29, 2023 15:55

jonathannorris force-pushed the DVC-9059-request-lib branch from db69e01 to 9c52d97 Compare September 29, 2023 18:21

jonathannorris commented Sep 29, 2023

View reviewed changes

lib/shared/config-manager/src/request.ts

)

}

async function getWithTimeout(

Copy link

Member Author

jonathannorris Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to common request lib

jonathannorris commented Sep 29, 2023

View reviewed changes

vercel bot deployed to Preview – js-sdks-next-js September 29, 2023 18:26 View deployment

vercel bot deployed to Preview – js-sdks-next-js September 29, 2023 18:30 View deployment

vercel bot deployed to Preview – js-sdks-with-provider September 29, 2023 18:31 View deployment

vercel bot deployed to Preview – js-sdks-web-elements September 29, 2023 18:31 View deployment

ajwootto reviewed Oct 2, 2023

View reviewed changes

lib/shared/server-request/src/index.ts Outdated Show resolved Hide resolved

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 82ce91a to d7a37aa Compare October 2, 2023 19:23

jonathannorris force-pushed the DVC-9059-request-lib branch from f024a01 to 235f361 Compare October 2, 2023 19:23

vercel bot deployed to Preview – js-sdks-web-elements October 2, 2023 19:33 View deployment

jonathannorris requested a review from ajwootto October 2, 2023 19:34

vercel bot deployed to Preview – js-sdks-web-elements October 2, 2023 19:38 View deployment

vercel bot deployed to Preview – js-sdks-next-js October 2, 2023 19:39 View deployment

jonathannorris force-pushed the DVC-9059-request-lib branch from 77cd079 to 3a8e1a2 Compare October 23, 2023 20:57

vercel bot deployed to Preview – js-sdks-with-provider October 23, 2023 21:06 View deployment

vercel bot deployed to Preview – js-sdks-next-js October 23, 2023 21:06 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 23, 2023 21:07 View deployment

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from adc5edf to 3ec54d0 Compare October 24, 2023 17:51

jonathannorris force-pushed the DVC-9059-request-lib branch from 3a8e1a2 to 360398a Compare October 24, 2023 17:51

vercel bot had a problem deploying to Preview – js-sdks-next-js October 24, 2023 17:58 Failure

vercel bot deployed to Preview – js-sdks-web-elements October 24, 2023 18:13 View deployment

vercel bot deployed to Preview – js-sdks-with-provider October 24, 2023 18:18 View deployment

jonathannorris force-pushed the DVC-9059-add-bundled-libraries branch from 3ec54d0 to d2cf865 Compare October 24, 2023 19:12

jonathannorris force-pushed the DVC-9059-request-lib branch from 360398a to edfe8fa Compare October 24, 2023 19:12

vercel bot had a problem deploying to Preview – js-sdks-next-js October 24, 2023 19:19 Failure

vercel bot deployed to Preview – js-sdks-with-provider October 24, 2023 19:30 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 24, 2023 19:30 View deployment

Base automatically changed from DVC-9059-add-bundled-libraries to main October 24, 2023 19:55

jonathannorris added 8 commits October 24, 2023 15:55

feat: remove core server request logic to new lib

d135682

fix: get tests working

1d19db9

fix: move UserError to request lib

94bf5f4

fix: update README

a38ed5f

fix: move server-request logic out of index.ts

edabe75

fix: prettier

9c446b4

fix: cleanup UserError

e1c6b9b

fix: update package.json

436dcc7

jonathannorris force-pushed the DVC-9059-request-lib branch from edfe8fa to 436dcc7 Compare October 24, 2023 19:55

vercel bot deployed to Preview – js-sdks-with-provider October 24, 2023 19:59 View deployment

vercel bot deployed to Preview – js-sdks-web-elements October 24, 2023 20:02 View deployment

vercel bot had a problem deploying to Preview – js-sdks-next-js October 24, 2023 20:02 Failure

ajwootto approved these changes Oct 24, 2023

View reviewed changes

jonathannorris merged commit 840adb3 into main Oct 24, 2023

jonathannorris deleted the DVC-9059-request-lib branch October 24, 2023 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: DVC9059 move core server request logic to new lib #565

feat: DVC9059 move core server request logic to new lib #565

Uh oh!

jonathannorris commented Sep 26, 2023 •

edited

Loading

Uh oh!

vercel bot commented Sep 26, 2023 •

edited

Loading

Uh oh!

jonathannorris commented Sep 26, 2023 •

edited

Loading

Uh oh!

jonathannorris Sep 29, 2023

Uh oh!

jonathannorris Sep 29, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

feat: DVC9059 move core server request logic to new lib #565

feat: DVC9059 move core server request logic to new lib #565

Uh oh!

Conversation

jonathannorris commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathannorris commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathannorris Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

jonathannorris Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jonathannorris commented Sep 26, 2023 •

edited

Loading

vercel bot commented Sep 26, 2023 •

edited

Loading

jonathannorris commented Sep 26, 2023 •

edited

Loading