fix: theme toggle icons not loading issue #435
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace invalid css.gg CDN link with correct jsDelivr URLs - Load moon.css and sun.css separately from cdn.jsdelivr.net - This fixes the gg-moon and gg-sun icons not displaying - Icons now properly show/hide on theme toggle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the theme toggle button icons (moon/sun) that were not displaying on the demo page.
Changes Made
Type of change
Files Changed
src/demo/index.php- Updated CDN links for moon and sun iconsHow Has This Been Tested?
Additional Notes
The fix ensures the icons are properly loaded from a reliable CDN (jsDelivr) - purely a bug fix for the icon loading issue.