Skip to content

Conversation

@avernikoz
Copy link
Collaborator

This PR renames the internal modules math, order, and pool to dt_math, dt_order, and dt_pool respectively.

Reasoning:
This is a workaround to bypass a known Sui Move compiler bug where automated address management (using 0x0 in Move.toml) causes namespace collisions when dependencies (like DeepBook) define modules with identical names.

References:

  • Fixes namespace collisions with DeepBook's math, order, and pool modules.
  • Bypasses Sui Issue #22194 (Namespace collision in dependencies).
  • Bypasses Sui Issue #20112 (Namespace collision between packages' dependencies).

Summary of Diff

The changes affect 34 files, primarily updating module declarations and their corresponding imports in both source files and test suites:

  • math.movedt_math
  • order.movedt_order
  • pool.movedt_pool
  • Updated references in fee.move, fee_manager.move, helper.move, and all associated unit tests.

@avernikoz avernikoz requested a review from bathord January 5, 2026 18:11
@avernikoz avernikoz merged commit 2302fa1 into DeeptradeProtocol:main Jan 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants