Skip to content

Intercom updates #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
deevus wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Intercom updates #290

deevus wants to merge 6 commits into from

Conversation

@deevus
Copy link
Contributor

@deevus deevus commented Jun 28, 2022 •
edited
Loading

Adds userHash option to Intercom configuration

Can now configure an Intercom user hash as detailed here: https://www.intercom.com/help/en/articles/183-enable-identity-verification-for-web-and-mobile

Better TypeScript types for Intercom plugin

  • Improved the JSDoc for the Intercom config object
  • Added tsconfig.json file for declaration emit configuration
  • Set browser types as default type for exported package (previously there was no types)

Fixed a types issue with the @analytics/types-util package

I don't know if this was working on your end, but lerna run types failed before this change.

Fixed loaded() method

Intercom isn't actually loaded until window.Intercom.booted is true

@deevus deevus force-pushed the intercom-user-hash branch from b346d2d to 05a50db Compare June 28, 2022 02:17
@deevus deevus force-pushed the intercom-user-hash branch from 05a50db to 27b621f Compare June 28, 2022 02:44
@deevus deevus changed the title Intercom: Add support for user_hash Intercom updates Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@deevus