Skip to content

Conversation

@Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Aug 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 14.53488% with 294 lines in your changes missing coverage. Please review.

Project coverage is 81.50%. Comparing base (de06f7a) to head (829b4e1).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
src/parser/global_rule_parser.cpp 0.00% 95 Missing ⚠️
src/rule/threshold_rule.cpp 0.00% 73 Missing ⚠️
src/rule/threshold_rule.hpp 0.00% 31 Missing ⚠️
src/lru_cache.hpp 0.00% 27 Missing ⚠️
src/global_context.cpp 0.00% 16 Missing ⚠️
src/parser/transformer_parser.cpp 0.00% 15 Missing ⚠️
src/ruleset_builder.cpp 13.33% 12 Missing and 1 partial ⚠️
src/sliding_window_counter.hpp 81.81% 2 Missing and 4 partials ⚠️
src/rule/base.hpp 50.00% 5 Missing ⚠️
src/global_context.hpp 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   84.54%   81.50%   -3.04%     
==========================================
  Files         150      159       +9     
  Lines        7666     7991     +325     
  Branches     3419     3580     +161     
==========================================
+ Hits         6481     6513      +32     
- Misses        457      742     +285     
- Partials      728      736       +8     
Flag Coverage Δ
waf_test 81.50% <14.53%> (-3.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Aug 19, 2024

Benchmarks

Benchmark execution time: 2024-10-21 20:32:15

Comparing candidate commit 829b4e1 in PR branch anilm3/global-context with baseline commit de06f7a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants