ci: check that PR title and source code changes are aligned #1414
+303
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2026-01-13 12:31:45 Comparing candidate commit 5d952a9 in PR branch Found 13 performance improvements and 11 performance regressions! Performance is the same for 33 metrics, 2 unstable metrics. scenario:benching serializing traces from their internal representation to msgpack
scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:profile_add_sample2_frames_x1000
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 71.31% 71.32% +0.01%
==========================================
Files 413 413
Lines 66157 66157
==========================================
+ Hits 47179 47187 +8
+ Misses 18978 18970 -8
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
hoolioh
changed the title
hoolioh
changed the base branch from
main
to
julio/versioning/enforce-conventional-commits-pr
iunanua
reviewed
Dec 22, 2025
iunanua
reviewed
Dec 23, 2025
iunanua
reviewed
Dec 23, 2025
iunanua
reviewed
Dec 23, 2025
iunanua
reviewed
Dec 24, 2025
Base automatically changed from
julio/versioning/enforce-conventional-commits-pr
to
main
January 8, 2026 12:04
hoolioh
force-pushed
the
julio/versioning/pr-semver-check
branch
2 times, most recently
from
3c6890c to
4ff4f16
Compare
Comment on lines
44
to
73
| while IFS= read -r crate_path; do | ||
| # Skip empty lines | ||
| if [[ -z "$crate_path" ]]; then | ||
| continue | ||
| fi | ||
|
|
||
| # Check if any files in this crate directory changed | ||
| if echo "$CHANGED_FILES" | grep -q "^${crate_path}/"; then | ||
| CRATE_MANIFEST="${crate_path}/Cargo.toml" | ||
|
|
||
| # Skip if Cargo.toml doesn't exist | ||
| if [[ ! -f "$CRATE_MANIFEST" ]]; then | ||
| continue | ||
| fi | ||
|
|
||
| # Check if crate has "publish = false" | ||
| if grep -q "^publish = false" "$CRATE_MANIFEST"; then | ||
| echo "Skipping unpublished crate: $crate_path" | ||
| continue | ||
| fi | ||
|
|
||
| # Extract crate name | ||
| CRATE_NAME=$(grep "^name = " "$CRATE_MANIFEST" | head -1 | sed 's/name = "\(.*\)"/\1/') | ||
|
|
||
| if [[ -n "$CRATE_NAME" ]]; then | ||
| echo "Detected change in published crate: $CRATE_NAME ($crate_path)" | ||
| CHANGED_CRATES+=("$CRATE_NAME") | ||
| fi | ||
| fi | ||
| done < <(sed -n 's/^ "\(.*\)",\?$/\1/p' Cargo.toml) |
Contributor
There was a problem hiding this comment.
I think this whole section would be less brittle if you just parsed the output of cargo metadata
A small jq script like this to grab the paths and names works for instance
cargo metadata | jq '.workspace_default_members as $members
| .packages
| map(
select(.id | IN($members[]))
| select(.publish == null)
| {name, path: .manifest_path | rtrimstr("/Cargo.toml")}
)'
Contributor
Author
There was a problem hiding this comment.
I'll definitely try that.
Contributor
Author
There was a problem hiding this comment.
@paullegranddc I've already tweaked the code. Let me know if it looks better.
paullegranddc
approved these changes
Jan 13, 2026
…changes in the PR.
* Use cargo-metadata to parse the list of crates that has changed. * Add publish field to build-common.
hoolioh
force-pushed
the
julio/versioning/pr-semver-check
branch
from
5d952a9 to
db33d39
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new workflow (pr-title-semver-check.yml) that automatically:
Validation Rules
The workflow enforces the following mappings between conventional commit types and API changes:
Technical Details
The workflow consists of three jobs:
Benefits