-
Notifications
You must be signed in to change notification settings - Fork 16
feat(appsec): add endpoints collection #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a120146 to
c6ec532
Compare
BenchmarksComparisonBenchmark execution time: 2026-01-14 14:41:57 Comparing candidate commit 07856fe in PR branch Found 1 performance improvements and 10 performance regressions! Performance is the same for 46 metrics, 2 unstable metrics. scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 07856fe | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 71.32% 71.34% +0.02%
==========================================
Files 416 417 +1
Lines 66781 66842 +61
==========================================
+ Hits 47631 47690 +59
- Misses 19150 19152 +2
🚀 New features to boost your workflow:
|
4869bfe to
b91ee92
Compare
1615cfa to
d749599
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
f6b569f to
436bbdf
Compare
801a248 to
e29de33
Compare
Co-authored-by: Gustavo Lopes <mail@geleia.net>
42c1895 to
7ce8e83
Compare
| _ = tokio::time::sleep(time::Duration::from_millis( | ||
| if let Some(endpoint) = self.config.endpoint.as_ref() { | ||
| endpoint.timeout_ms | ||
| } else { | ||
| libdd_common::Endpoint::DEFAULT_TIMEOUT | ||
| })) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
What does this PR do?
This PR allow to collect endpoints. The idea is that the php extension at startup will collect all framework endpoints and send them to here so they are then send to the backend
Motivation
Populate all endpoints on an app