Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Jan 13, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

… before starting kafka

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 13, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

ext/standard/tests/network/gh12190.phpt (Bug #12190 (Setting 0 with port 0 too)) from php.ext.standard.tests.network (Datadog) (Fix with Cursor)
001- bool(true)
002+  in /usr/local/src/php/ext/standard/tests/network/gh12190.php on line 3
003+ bool(false)
ext/standard/tests/network/bug80067.phpt (Bug #80067 (Omitting the port in bindto setting errors)) from PHP.ext.standard.tests.network (Datadog) (Fix with Cursor)
001- bool(true)
002+  in /usr/local/src/php/ext/standard/tests/network/bug80067.php on line 3
003+ bool(false)

🧪 2063 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6966799500000000d201bc1e6ec3ea38
tid: 6966799500000000
hexProcessTraceId: d201bc1e6ec3ea38
hexProcessSpanId: ff45cf157ba2d43f
processTraceId: 15132583061834951224
processSpanId: 18394335944240190527

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

    testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Fix with Cursor)

View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f6b9f95 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-13 16:47:55

Comparing candidate commit f6b9f95 in PR branch leiyks/fix-sqlsrv-and-laravel-octane-flakiness with baseline commit 4a26042 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@Leiyks Leiyks force-pushed the leiyks/fix-sqlsrv-and-laravel-octane-flakiness branch from dc4603b to e5e9236 Compare January 13, 2026 16:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.90%. Comparing base (4a26042) to head (f6b9f95).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3574   +/-   ##
=======================================
  Coverage   61.90%   61.90%           
=======================================
  Files         140      140           
  Lines       13281    13281           
  Branches     1758     1758           
=======================================
  Hits         8221     8221           
  Misses       4272     4272           
  Partials      788      788           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a26042...f6b9f95. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/fix-sqlsrv-and-laravel-octane-flakiness branch from e5e9236 to f6b9f95 Compare January 13, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants