Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Jan 13, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@datadog-official
Copy link

datadog-official bot commented Jan 13, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 12 New flaky tests detected

getdate_variation3.phpt - Test getdate() function : usage variation - Passing hexadcimal timestamp values from php-src.php-src.ext.date.tests (Datadog) (Fix with Cursor)
081+ thread '<unnamed>' panicked at libdatadog/libdd-crashtracker/src/collector/process_handle.rs:21:9:
082+ assertion \`left == right\` failed: wait_for_pollhup failed: Ok(false)
083+   left: Ok(false)
084+  right: Ok(true)
085+ note: run with \`RUST_BACKTRACE=1\` environment variable to display a backtrace
086+ thread '<unnamed>' panicked at core/src/panicking.rs:223:5:
087+ panic in a function that cannot unwind
088+ stack backtrace:
089+ panicked at std/src/../../backtrace/src/backtrace/libunwind.rs:109:13:
090+ cannot panic during the backtrace function
...
bug54970.phpt - Bug #54970 (SplFixedArray::setSize() isn't resizing) from php-src.php-src.ext.spl.tests (Datadog) (Fix with Cursor)
016+ Segmentation fault (core dumped)
017+ 
018+ Termsig=11
bug73029.phpt - Bug #73029: Missing type check when unserializing SplArray from php-src.php-src.ext.spl.tests (Datadog) (Fix with Cursor)
003+ Segmentation fault (core dumped)
004+ 
005+ Termsig=11
View all

🧪 2344 Tests failed

testInstrumentation from custom-framework-autoloading-test.DDTrace\Tests\Integrations\Custom\Autoloaded\InstrumentationTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Custom\Autoloaded\InstrumentationTest::testInstrumentation
Failed asserting that an array has the key 'logs_created'.

tests/Integrations/Custom/Autoloaded/InstrumentationTest.php:79
tests/Common/RetryTraitVersionGeneric.php:28

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fc0350a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.91%. Comparing base (4a26042) to head (fc0350a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3573      +/-   ##
==========================================
+ Coverage   61.90%   61.91%   +0.01%     
==========================================
  Files         140      140              
  Lines       13281    13281              
  Branches     1758     1758              
==========================================
+ Hits         8221     8223       +2     
+ Misses       4272     4269       -3     
- Partials      788      789       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a26042...fc0350a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-13 14:17:00

Comparing candidate commit fc0350a in PR branch leiyks/sidecar-threaded-fallback with baseline commit 4a26042 in branch master.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+4.420µs; +5.080µs] or [+4.383%; +5.039%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+2.479µs; +3.981µs] or [+2.328%; +3.739%]

scenario:PHPRedisBench/benchRedisBaseline-opcache

  • 🟩 execution_time [-4.501µs; -3.165µs] or [-3.094%; -2.175%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+97.710ns; +142.890ns] or [+8.351%; +12.212%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+88.020ns; +159.380ns] or [+7.557%; +13.684%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+90.883ns; +144.317ns] or [+7.784%; +12.361%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+109.747ns; +148.853ns] or [+9.522%; +12.915%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants