Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 12, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 12, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1022 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696818e500000000ea1919d2d507c70f
tid: 696818e500000000
hexProcessTraceId: ea1919d2d507c70f
hexProcessSpanId: 60ac12fdca063095
processTraceId: 16868542272600786703
processSpanId: 6965963604860743829
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 031007d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.93%. Comparing base (88a859c) to head (031007d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   62.02%   61.93%   -0.10%     
==========================================
  Files         140      140              
  Lines       13309    13309              
  Branches     1762     1762              
==========================================
- Hits         8255     8243      -12     
- Misses       4265     4275      +10     
- Partials      789      791       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a859c...031007d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubloom dubloom force-pushed the dubloom/bump-libdatadog-version branch from 67ec141 to 93c4b08 Compare January 13, 2026 13:40
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-14 21:35:27

Comparing candidate commit 031007d in PR branch dubloom/bump-libdatadog-version with baseline commit 88a859c in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 6 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 cpu_user_time [+36.307ms; +81.559ms] or [+2.318%; +5.208%]

@dubloom dubloom force-pushed the dubloom/bump-libdatadog-version branch from 88513f9 to b83716e Compare January 13, 2026 14:21
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-14 22:29:35

Comparing candidate commit 031007d in PR branch dubloom/bump-libdatadog-version with baseline commit 88a859c in branch master.

Found 0 performance improvements and 8 performance regressions! Performance is the same for 186 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟥 execution_time [+0.882µs; +1.718µs] or [+8.644%; +16.846%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.610µs; +4.510µs] or [+3.494%; +4.365%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+6.910µs; +7.670µs] or [+6.493%; +7.207%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+19.633µs; +51.070µs] or [+2.278%; +5.926%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+74.969ns; +143.431ns] or [+6.346%; +12.142%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+98.101ns; +131.099ns] or [+8.400%; +11.226%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+87.020ns; +139.580ns] or [+7.381%; +11.840%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+83.432ns; +136.168ns] or [+7.095%; +11.579%]

@bwoebi bwoebi force-pushed the dubloom/bump-libdatadog-version branch 2 times, most recently from acc1373 to f462374 Compare January 14, 2026 12:54
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the dubloom/bump-libdatadog-version branch from f462374 to fc8378e Compare January 14, 2026 13:57
@bwoebi bwoebi marked this pull request as ready for review January 14, 2026 13:57
@bwoebi bwoebi requested review from a team as code owners January 14, 2026 13:57
@bwoebi bwoebi requested a review from a team as a code owner January 14, 2026 19:38
@bwoebi bwoebi force-pushed the dubloom/bump-libdatadog-version branch from 3cb3722 to 031007d Compare January 14, 2026 21:18
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial work @dubloom :-)

@bwoebi bwoebi merged commit 323b5e1 into master Jan 15, 2026
2003 of 2008 checks passed
@bwoebi bwoebi deleted the dubloom/bump-libdatadog-version branch January 15, 2026 00:08
@github-actions github-actions bot added this to the 1.16.0 milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants