-
Notifications
You must be signed in to change notification settings - Fork 166
feat(Symfony): Check cache.app is reachable before use #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Benchmarks [ tracer ]Benchmark execution time: 2025-12-03 16:02:16 Comparing candidate commit ea33259 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3514 +/- ##
==========================================
- Coverage 61.81% 61.69% -0.12%
==========================================
Files 142 142
Lines 12923 12923
Branches 1695 1695
==========================================
- Hits 7988 7973 -15
- Misses 4183 4196 +13
- Partials 752 754 +2 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
7b789c3 to
84db2cc
Compare
…mcached Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
84db2cc to
ea33259
Compare
| ) { | ||
| $reflection = new \ReflectionClass($adapter); | ||
| $redisProperty = $reflection->getProperty('redis'); | ||
| $redisProperty->setAccessible(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a PHP_VERSION_ID < 80000 check to avoid deprecations
Description
This PR add a readyness check on the Symfony cache app in case the service is unavailable.
The absence of this check can be the cause for significant latency increase when the cache app is not available as we are fetching all the routes in that case.