Skip to content

Refactor SMAP parser #10385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpbempel wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor SMAP parser #10385

jpbempel wants to merge 8 commits into from
+483 −585

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Jan 15, 2026 •
edited by bric3
Loading

What Does This Do

Simplify code, reduce allocations
remove checked exceptions
use an enum for builders
move packages

Motivation

Reuse for Kotlin classes

Additional Notes

Related to

Note

There is no difference in the SMAP syntax between JSR 45 and Jakarta Debugging Support for Other Languages 2.0. The technical specification (grammar, sections, format) is identical.

Version History

Version Year Description
JSR 45 2003 Original specification from Java Community Process
Jakarta 1.0 2019 Re-release of JSR 45 under Eclipse Foundation Specification License (EFSL) for Jakarta EE 8
Jakarta 2.0 2020 Namespace migration from javax.* to jakarta.* for Jakarta EE 9

What Changed

  • Jakarta 1.0: Licensing only (JCP → EFSL). Explicitly documented as "a re-release of JSR 45 under the EFSL".
  • Jakarta 2.0: Namespace change (javax.* → jakarta.*) as part of Jakarta EE 9.

SMAP Syntax

The SMAP grammar remains unchanged across all versions:

  • StratumSection, FileSection, LineSection, VendorSection, EmbeddedSourceMaps — all identical.

References

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel
Refactor SMAP parser
df6296e 
Simplify code, reduce allocations
remove checked exceptions
use an enum for builders
@jpbempel
move packages
7c03868
@jpbempel jpbempel requested review from a team as code owners January 15, 2026 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added comp: tooling Build & Tooling type: refactoring tag: no release notes Changes to exclude from release notes labels Jan 15, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/refactor-smap
git_commit_date 1768469296 1768512705
git_commit_sha 288e1bb 7c3d62b
release_version 1.59.0-SNAPSHOT~288e1bb70a 1.59.0-SNAPSHOT~7c3d62b2ad
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1768514654 1768514654
ci_job_id 1354341803 1354341803
ci_pipeline_id 90992344 90992344
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-9be5hwfo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-9be5hwfo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084188
Total [baseline] (8.745 s) : 0, 8744575
Agent [candidate] (1.091 s) : 0, 1090956
Total [candidate] (8.722 s) : 0, 8721578
section iast
Agent [baseline] (1.223 s) : 0, 1223025
Total [baseline] (9.274 s) : 0, 9273697
Agent [candidate] (1.23 s) : 0, 1230316
Total [candidate] (9.297 s) : 0, 9297142
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.223 s 138.838 ms (12.8%)
Total tracing 8.745 s -
Total iast 9.274 s 529.123 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.23 s 139.36 ms (12.8%)
Total tracing 8.722 s -
Total iast 9.297 s 575.564 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (652.162 ms) : 0, 652162
BytebuddyAgent [candidate] (656.018 ms) : 0, 656018
GlobalTracer [baseline] (282.487 ms) : 0, 282487
GlobalTracer [candidate] (284.434 ms) : 0, 284434
AppSec [baseline] (32.614 ms) : 0, 32614
AppSec [candidate] (32.923 ms) : 0, 32923
Debugger [baseline] (66.759 ms) : 0, 66759
Debugger [candidate] (67.334 ms) : 0, 67334
Remote Config [baseline] (629.222 µs) : 0, 629
Remote Config [candidate] (636.897 µs) : 0, 637
Telemetry [baseline] (9.018 ms) : 0, 9018
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (3.791 ms) : 0, 3791
Flare Poller [candidate] (3.888 ms) : 0, 3888
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (791.488 ms) : 0, 791488
BytebuddyAgent [candidate] (798.432 ms) : 0, 798432
GlobalTracer [baseline] (256.491 ms) : 0, 256491
GlobalTracer [candidate] (257.046 ms) : 0, 257046
AppSec [baseline] (34.897 ms) : 0, 34897
AppSec [candidate] (33.528 ms) : 0, 33528
Debugger [baseline] (63.979 ms) : 0, 63979
Debugger [candidate] (65.28 ms) : 0, 65280
Remote Config [baseline] (568.795 µs) : 0, 569
Remote Config [candidate] (575.104 µs) : 0, 575
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (8.373 ms) : 0, 8373
Flare Poller [baseline] (3.63 ms) : 0, 3630
Flare Poller [candidate] (3.571 ms) : 0, 3571
IAST [baseline] (26.893 ms) : 0, 26893
IAST [candidate] (26.897 ms) : 0, 26897
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084341
Total [baseline] (10.755 s) : 0, 10754851
Agent [candidate] (1.086 s) : 0, 1085723
Total [candidate] (10.801 s) : 0, 10800883
section appsec
Agent [baseline] (1.265 s) : 0, 1265127
Total [baseline] (10.998 s) : 0, 10997529
Agent [candidate] (1.276 s) : 0, 1275756
Total [candidate] (11.078 s) : 0, 11078448
section iast
Agent [baseline] (1.224 s) : 0, 1223841
Total [baseline] (11.225 s) : 0, 11224727
Agent [candidate] (1.235 s) : 0, 1234725
Total [candidate] (11.306 s) : 0, 11305911
section profiling
Agent [baseline] (1.217 s) : 0, 1216629
Total [baseline] (10.907 s) : 0, 10906700
Agent [candidate] (1.218 s) : 0, 1217790
Total [candidate] (10.859 s) : 0, 10859041
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.265 s 180.786 ms (16.7%)
Agent iast 1.224 s 139.5 ms (12.9%)
Agent profiling 1.217 s 132.288 ms (12.2%)
Total tracing 10.755 s -
Total appsec 10.998 s 242.679 ms (2.3%)
Total iast 11.225 s 469.876 ms (4.4%)
Total profiling 10.907 s 151.849 ms (1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.276 s 190.034 ms (17.5%)
Agent iast 1.235 s 149.003 ms (13.7%)
Agent profiling 1.218 s 132.068 ms (12.2%)
Total tracing 10.801 s -
Total appsec 11.078 s 277.565 ms (2.6%)
Total iast 11.306 s 505.028 ms (4.7%)
Total profiling 10.859 s 58.158 ms (0.5%) 
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (651.346 ms) : 0, 651346
BytebuddyAgent [candidate] (652.843 ms) : 0, 652843
GlobalTracer [baseline] (282.515 ms) : 0, 282515
GlobalTracer [candidate] (282.681 ms) : 0, 282681
AppSec [baseline] (32.511 ms) : 0, 32511
AppSec [candidate] (32.461 ms) : 0, 32461
Debugger [baseline] (67.949 ms) : 0, 67949
Debugger [candidate] (67.705 ms) : 0, 67705
Remote Config [baseline] (643.248 µs) : 0, 643
Remote Config [candidate] (648.634 µs) : 0, 649
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.964 ms) : 0, 8964
Flare Poller [baseline] (3.802 ms) : 0, 3802
Flare Poller [candidate] (3.776 ms) : 0, 3776
section appsec
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (689.75 ms) : 0, 689750
BytebuddyAgent [candidate] (696.631 ms) : 0, 696631
GlobalTracer [baseline] (259.556 ms) : 0, 259556
GlobalTracer [candidate] (261.474 ms) : 0, 261474
AppSec [baseline] (174.108 ms) : 0, 174108
AppSec [candidate] (174.108 ms) : 0, 174108
Debugger [baseline] (66.637 ms) : 0, 66637
Debugger [candidate] (67.765 ms) : 0, 67765
Remote Config [baseline] (767.474 µs) : 0, 767
Remote Config [candidate] (793.929 µs) : 0, 794
Telemetry [baseline] (9.233 ms) : 0, 9233
Telemetry [candidate] (9.373 ms) : 0, 9373
Flare Poller [baseline] (3.789 ms) : 0, 3789
Flare Poller [candidate] (3.78 ms) : 0, 3780
IAST [baseline] (24.76 ms) : 0, 24760
IAST [candidate] (25.058 ms) : 0, 25058
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (791.488 ms) : 0, 791488
BytebuddyAgent [candidate] (799.506 ms) : 0, 799506
GlobalTracer [baseline] (256.489 ms) : 0, 256489
GlobalTracer [candidate] (257.784 ms) : 0, 257784
AppSec [baseline] (34.996 ms) : 0, 34996
AppSec [candidate] (33.752 ms) : 0, 33752
Debugger [baseline] (64.529 ms) : 0, 64529
Debugger [candidate] (66.984 ms) : 0, 66984
Remote Config [baseline] (563.851 µs) : 0, 564
Remote Config [candidate] (583.88 µs) : 0, 584
Telemetry [baseline] (8.443 ms) : 0, 8443
Telemetry [candidate] (8.531 ms) : 0, 8531
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.621 ms) : 0, 3621
IAST [baseline] (27.086 ms) : 0, 27086
IAST [candidate] (27.278 ms) : 0, 27278
section profiling
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (710.857 ms) : 0, 710857
BytebuddyAgent [candidate] (710.421 ms) : 0, 710421
GlobalTracer [baseline] (222.624 ms) : 0, 222624
GlobalTracer [candidate] (223.22 ms) : 0, 223220
AppSec [baseline] (32.284 ms) : 0, 32284
AppSec [candidate] (32.699 ms) : 0, 32699
Debugger [baseline] (68.328 ms) : 0, 68328
Debugger [candidate] (68.662 ms) : 0, 68662
Remote Config [baseline] (643.187 µs) : 0, 643
Remote Config [candidate] (647.32 µs) : 0, 647
Telemetry [baseline] (9.078 ms) : 0, 9078
Telemetry [candidate] (9.038 ms) : 0, 9038
Flare Poller [baseline] (3.864 ms) : 0, 3864
Flare Poller [candidate] (4.406 ms) : 0, 4406
ProfilingAgent [baseline] (97.123 ms) : 0, 97123
ProfilingAgent [candidate] (96.7 ms) : 0, 96700
Profiling [baseline] (97.711 ms) : 0, 97711
Profiling [candidate] (97.301 ms) : 0, 97301
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/refactor-smap
git_commit_date 1768469296 1768512705
git_commit_sha 288e1bb 7c3d62b
release_version 1.59.0-SNAPSHOT~288e1bb70a 1.59.0-SNAPSHOT~7c3d62b2ad
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1768515060 1768515060
ci_job_id 1354341804 1354341804
ci_pipeline_id 90992344 90992344
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-8o2a2un8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-8o2a2un8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-164.303µs; -69.362µs] or [-5.738%; -2.422%]		 same
[-349.629µs; +99.016µs] or [-4.345%; +1.231%]		 unstable
[-109.019op/s; +174.269op/s] or [-8.625%; +13.788%]		 2.747ms 7.921ms 1296.562op/s 2.864ms 8.046ms 1263.938op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.216 ms) : 1204, 1228
.   : milestone, 1216,
iast (3.232 ms) : 3192, 3272
.   : milestone, 3232,
iast_FULL (5.847 ms) : 5788, 5905
.   : milestone, 5847,
iast_GLOBAL (3.63 ms) : 3573, 3687
.   : milestone, 3630,
profiling (1.935 ms) : 1918, 1952
.   : milestone, 1935,
tracing (1.87 ms) : 1854, 1886
.   : milestone, 1870,
section candidate
no_agent (1.187 ms) : 1175, 1199
.   : milestone, 1187,
iast (3.242 ms) : 3200, 3285
.   : milestone, 3242,
iast_FULL (5.721 ms) : 5666, 5777
.   : milestone, 5721,
iast_GLOBAL (3.537 ms) : 3478, 3596
.   : milestone, 3537,
profiling (1.982 ms) : 1965, 2000
.   : milestone, 1982,
tracing (1.774 ms) : 1760, 1788
.   : milestone, 1774,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.216 ms [1.204 ms, 1.228 ms] -
iast 3.232 ms [3.192 ms, 3.272 ms] 2.016 ms (165.8%)
iast_FULL 5.847 ms [5.788 ms, 5.905 ms] 4.63 ms (380.8%)
iast_GLOBAL 3.63 ms [3.573 ms, 3.687 ms] 2.413 ms (198.5%)
profiling 1.935 ms [1.918 ms, 1.952 ms] 718.831 µs (59.1%)
tracing 1.87 ms [1.854 ms, 1.886 ms] 653.828 µs (53.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.187 ms [1.175 ms, 1.199 ms] -
iast 3.242 ms [3.2 ms, 3.285 ms] 2.055 ms (173.1%)
iast_FULL 5.721 ms [5.666 ms, 5.777 ms] 4.534 ms (381.9%)
iast_GLOBAL 3.537 ms [3.478 ms, 3.596 ms] 2.35 ms (197.9%)
profiling 1.982 ms [1.965 ms, 2.0 ms] 795.08 µs (67.0%)
tracing 1.774 ms [1.76 ms, 1.788 ms] 586.511 µs (49.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.543 ms) : 19342, 19743
.   : milestone, 19543,
appsec (18.625 ms) : 18430, 18819
.   : milestone, 18625,
code_origins (17.423 ms) : 17249, 17597
.   : milestone, 17423,
iast (17.851 ms) : 17673, 18028
.   : milestone, 17851,
profiling (19.779 ms) : 19577, 19982
.   : milestone, 19779,
tracing (17.542 ms) : 17368, 17715
.   : milestone, 17542,
section candidate
no_agent (18.903 ms) : 18710, 19096
.   : milestone, 18903,
appsec (18.262 ms) : 18077, 18447
.   : milestone, 18262,
code_origins (17.952 ms) : 17773, 18130
.   : milestone, 17952,
iast (17.64 ms) : 17462, 17818
.   : milestone, 17640,
profiling (19.424 ms) : 19225, 19623
.   : milestone, 19424,
tracing (17.506 ms) : 17332, 17681
.   : milestone, 17506,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.543 ms [19.342 ms, 19.743 ms] -
appsec 18.625 ms [18.43 ms, 18.819 ms] -917.832 µs (-4.7%)
code_origins 17.423 ms [17.249 ms, 17.597 ms] -2.12 ms (-10.8%)
iast 17.851 ms [17.673 ms, 18.028 ms] -1.692 ms (-8.7%)
profiling 19.779 ms [19.577 ms, 19.982 ms] 236.727 µs (1.2%)
tracing 17.542 ms [17.368 ms, 17.715 ms] -2.001 ms (-10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.903 ms [18.71 ms, 19.096 ms] -
appsec 18.262 ms [18.077 ms, 18.447 ms] -641.687 µs (-3.4%)
code_origins 17.952 ms [17.773 ms, 18.13 ms] -951.821 µs (-5.0%)
iast 17.64 ms [17.462 ms, 17.818 ms] -1.263 ms (-6.7%)
profiling 19.424 ms [19.225 ms, 19.623 ms] 520.79 µs (2.8%)
tracing 17.506 ms [17.332 ms, 17.681 ms] -1.397 ms (-7.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/refactor-smap
git_commit_date 1768469296 1768512705
git_commit_sha 288e1bb 7c3d62b
release_version 1.59.0-SNAPSHOT~288e1bb70a 1.59.0-SNAPSHOT~7c3d62b2ad
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1768514832 1768514832
ci_job_id 1354341805 1354341805
ci_pipeline_id 90992344 90992344
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-evww4f24 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-evww4f24 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.699 s) : 15699000, 15699000
.   : milestone, 15699000,
appsec (14.64 s) : 14640000, 14640000
.   : milestone, 14640000,
iast (18.392 s) : 18392000, 18392000
.   : milestone, 18392000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
.   : milestone, 18048000,
profiling (14.746 s) : 14746000, 14746000
.   : milestone, 14746000,
tracing (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
section candidate
no_agent (15.563 s) : 15563000, 15563000
.   : milestone, 15563000,
appsec (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
iast (18.407 s) : 18407000, 18407000
.   : milestone, 18407000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
.   : milestone, 17878000,
profiling (14.728 s) : 14728000, 14728000
.   : milestone, 14728000,
tracing (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.699 s [15.699 s, 15.699 s] -
appsec 14.64 s [14.64 s, 14.64 s] -1.059 s (-6.7%)
iast 18.392 s [18.392 s, 18.392 s] 2.693 s (17.2%)
iast_GLOBAL 18.048 s [18.048 s, 18.048 s] 2.349 s (15.0%)
profiling 14.746 s [14.746 s, 14.746 s] -953.0 ms (-6.1%)
tracing 14.871 s [14.871 s, 14.871 s] -828.0 ms (-5.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.563 s [15.563 s, 15.563 s] -
appsec 15.112 s [15.112 s, 15.112 s] -451.0 ms (-2.9%)
iast 18.407 s [18.407 s, 18.407 s] 2.844 s (18.3%)
iast_GLOBAL 17.878 s [17.878 s, 17.878 s] 2.315 s (14.9%)
profiling 14.728 s [14.728 s, 14.728 s] -835.0 ms (-5.4%)
tracing 15.002 s [15.002 s, 15.002 s] -561.0 ms (-3.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~7c3d62b2ad, baseline=1.59.0-SNAPSHOT~288e1bb70a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (3.734 ms) : 3513, 3955
.   : milestone, 3734,
iast (2.221 ms) : 2156, 2286
.   : milestone, 2221,
iast_GLOBAL (2.257 ms) : 2191, 2322
.   : milestone, 2257,
profiling (2.073 ms) : 2020, 2126
.   : milestone, 2073,
tracing (2.05 ms) : 1999, 2101
.   : milestone, 2050,
section candidate
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.709 ms) : 3489, 3929
.   : milestone, 3709,
iast (2.221 ms) : 2156, 2285
.   : milestone, 2221,
iast_GLOBAL (2.272 ms) : 2206, 2337
.   : milestone, 2272,
profiling (2.479 ms) : 2267, 2691
.   : milestone, 2479,
tracing (2.057 ms) : 2006, 2108
.   : milestone, 2057,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 3.734 ms [3.513 ms, 3.955 ms] 2.256 ms (152.7%)
iast 2.221 ms [2.156 ms, 2.286 ms] 742.883 µs (50.3%)
iast_GLOBAL 2.257 ms [2.191 ms, 2.322 ms] 778.736 µs (52.7%)
profiling 2.073 ms [2.02 ms, 2.126 ms] 595.239 µs (40.3%)
tracing 2.05 ms [1.999 ms, 2.101 ms] 572.261 µs (38.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 3.709 ms [3.489 ms, 3.929 ms] 2.232 ms (151.2%)
iast 2.221 ms [2.156 ms, 2.285 ms] 743.842 µs (50.4%)
iast_GLOBAL 2.272 ms [2.206 ms, 2.337 ms] 794.856 µs (53.8%)
profiling 2.479 ms [2.267 ms, 2.691 ms] 1.003 ms (67.9%)
tracing 2.057 ms [2.006 ms, 2.108 ms] 580.159 µs (39.3%)

bric3
bric3 reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !

...va-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/StratumManager.java Outdated
Comment on lines 34 to 39
public static boolean shouldBeAnalyzed(final String internalClassName) {
return internalClassName.contains("jsp")
&& (internalClassName.contains("_jsp")
|| internalClassName.contains("jsp_")
|| internalClassName.contains("_tag"));
}
Copy link
Contributor

@bric3 bric3 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Maybe this method needs to be moved as too jsp specific ?

...va-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/StratumManager.java Outdated
private final LimitedConcurrentHashMap map;

public static final StratumManager INSTANCE =
new StratumManager(Config.get().getIastSourceMappingMaxSize());
Copy link
Contributor

@bric3 bric3 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Maybe Iast should have its own instance ? And debugger it's own too.

...va-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/stratum/StratumManager.java Outdated
}
map.put(className, value);
if (this.size() >= maxSize) {
IastMetricCollector.add(IastMetric.SOURCE_MAPPING_LIMIT_REACHED, 1);
Copy link
Contributor

@bric3 bric3 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Maybe extract that too in the constructor ?

@bric3
Copy link
Contributor

bric3 commented Jan 15, 2026 

> Task :dd-java-agent:instrumentation:datadog:asm:iast-instrumenter:test
SourceMapperImplTest > test getFileAndLine FAILED
    java.lang.ClassCastException at SourceMapperImplTest.groovy:40

Groovy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 left review comments

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@claponcet claponcet Awaiting requested review from claponcet claponcet is a code owner automatically assigned from DataDog/asm-java

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @bric3