fix trigger halos not un-triggering for passive sources or sinks #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the late upload, this was originally going to be more than just one fix, but then I found out why the other fixes weren't fixed yet - as they quite complicated. Will continue trying.
Trigger halos currently don't 'unset' unless they transfer actively to or from the current node to a passive node. It will work for gather nodes when pulling from a provider, but doesn't work for a provider node being pulled from from a gather node node. Essentially, it wouldn't unset if the node doesn't incur a transfer cooldown.