-
Notifications
You must be signed in to change notification settings - Fork 63
Feature: Add element and user data to mesh handle #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lenaploetzke
wants to merge
15
commits into
handle-neighbor-and-ghost
Choose a base branch
from
handle_element-data
base: handle-neighbor-and-ghost
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## handle-neighbor-and-ghost #2005 +/- ##
=============================================================
+ Coverage 77.12% 77.16% +0.03%
=============================================================
Files 111 111
Lines 18821 18851 +30
=============================================================
+ Hits 14516 14546 +30
Misses 4305 4305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2006
Describe your changes here:
The mesh handle class is now able to handle element and user data. Template parameters are used to specify the classes (instead of the void* used in the forest for the user data). To specify them as template parameters, i needed to somehow pack the Competences into one template parameter (see parameter_pack.hxx) (because i wanted defaults for the element and user data classes but a parameter pack also always has to be the last template parameter). I think its a feature to have them all in one template parameter for the user and makes it easier to use (although slightly more complicated as a developer). Additionally, i can now provide predefined parameter packs e.g. cache_competences, where all cache competences are included.
The element data is stored in a vector in the mesh (and not in the elements). This is easier for the ghost exchange.
Additionally, the volume of the elements can now be accessed and cached. A tutorial used this as element data which is why i got inspired and also implemented the functionality for the handle. The calculation can be somehow complicated which is why i also provide a cached version.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).