Skip to content

Conversation

@lukasdreyer
Copy link
Collaborator

@lukasdreyer lukasdreyer commented Oct 21, 2025

Closes #1908

Describe your changes here:
Introduce profiling barrier option.
TODO: Actually use these before SC_WTIME in communication based timings

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.64%. Comparing base (98ed04c) to head (c229d0d).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           enhancement-search_timing    #1906   +/-   ##
==========================================================
  Coverage                      75.64%   75.64%           
==========================================================
  Files                            103      103           
  Lines                          19273    19273           
==========================================================
  Hits                           14580    14580           
  Misses                          4693     4693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasdreyer lukasdreyer force-pushed the enhancement-profile_barrier branch from 9da423e to 5e8c323 Compare October 22, 2025 11:36
@lukasdreyer lukasdreyer changed the base branch from main to enhancement-search_timing October 22, 2025 11:37
@lukasdreyer lukasdreyer force-pushed the enhancement-search_timing branch from 916d880 to 19c4bc6 Compare October 22, 2025 13:57
@lukasdreyer lukasdreyer force-pushed the enhancement-profile_barrier branch 2 times, most recently from 68068ef to 702e98a Compare October 22, 2025 14:04
lukasdreyer and others added 4 commits October 22, 2025 16:16
fix variable name in endif statement

Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
@lukasdreyer lukasdreyer force-pushed the enhancement-profile_barrier branch from 702e98a to c229d0d Compare October 22, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add profiling barrier option to cmake

3 participants