Skip to content

Fixes for clang-tidy warnings and memory issues reported by sanitizers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikucionisaau wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fixes for clang-tidy warnings and memory issues reported by sanitizers #3

mikucionisaau wants to merge 15 commits into from

Conversation

@mikucionisaau
Copy link
Member

@mikucionisaau mikucionisaau commented Aug 13, 2025 •
edited
Loading

  • fix some clang-tidy warnings
  • refactor random data generation for tests
  • add const for readability
  • replace flexible array (C-only feature frowned upon in C++) with std::unique_ptr
  • fix memory alignment when reading and writing into compressed storage
  • fix iterator underflow and overflow
  • fix heap-buffer-overflow
  • fix heap-use-after-free
  • fix memory leaks

@mikucionisaau
Fixed clang-tidy warnings and refactored (test) random data generation
e328d57
@mikucionisaau
Refactored random data generation, add const and some more cleanups
27c028b
@mikucionisaau
More test fixes
034650a
@mikucionisaau
Replaced flexible array with std::vector to shutup the warnings and i…
c42f4b5 
…mprove safety by tracking explicit ownership
@mikucionisaau
Replaced std::vector with unique_ptr to minimize the overhead of size…
0a18990 
… and capacity
@mikucionisaau
Fixed some memory alignement issues reported by sanitizer
1253a41
@mikucionisaau
Fixed underflow and overflow when iterating
3e42bde
@mikucionisaau
Fixed clang errors and warnings, added specific memory leak logging (…
e148456 
…GCC sanitizer fails to record the precise line numbers)
@mikucionisaau
Fixed memory alignment warnings
bb86d1b
@mikucionisaau
Re-added typename for AppleClang
b061346
@mikucionisaau
Added constructors for puint16_t used for type-punning
612bcbd
@mikucionisaau
Improved leak logging
6a97831
@mikucionisaau
Added workarounds for AppleClang from Xcode-15.4 and older
80c81b2
@mikucionisaau
GH CI: enabled debug build and test on older macOS
84d5bd3
@mikucionisaau
GH CI: enabled sanitizers
e725059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikucionisaau