Add a share page #71
Open
Add a share page #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I meant the page solely as a fallback when JS is off, but maybe that is too much work for it. No popup windows, please, everyone hates them. By "popup" I mean the HTML kind, e.g. like here on GitHub when you click the "add reaction" button. There is one already in DFeed to go to a specific page on the thread overview bar. |
Owner
|
famfamfam icons predate the new "share" icon that's universal now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom share page and tries to tackle #63.
Currently the page looks ugly, so see this as a WIP.
Please note that the JS used is optional and just sets the size of the window opened. It works well without JS and no external (tracking) js is loaded.
Also I am not sure anymore whether providing a separate page is really the way to go.
What is your impression @CyberShadow?