Skip to content

Conversation

@ScottA38
Copy link

- Updated query response failure to be more verbose

2 things to note about this PR:

  • I am not a Ruby dev so I couldn't figure out how to add newlines in the error message, or use best practises
  • This is quite possibly only applicable to Github requests, an assumption is made that Gql will only return JSON though, and I check for the appropriate key 'message' safely, so I think it is a a safe implementation, maybe you can comment

	- Updated query response failure to be more verbose
	- Updated verbose output to check if reponse provided from query error is JSON
	- Changed variable misnaming in handleResponse
@ScottA38
Copy link
Author

@Crunch09 Hey, long time no speak, I am wondering if this PR is potentially still useful to you?

Is the repo still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant