Merge gc-shared-resources into codebase
#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Closes #46.
gc-shared-nuxt-resourcesis being deprecated since we are only using it in two codebases, the actual code is not likely to change much ever, and it is causing an unnecessarily poor DX.Adopts @conservationtimothy's approach in ConservationMetrics/gc-explorer#153 to merge all of the relevant code (Auth, Language Picker, middleware), and add the ability to store redirect path in Session Storage for a good redirect experience post-login.
In working on this, I also had to bump the version of
@nuxtjs/i18nand change locale paths.