-
Notifications
You must be signed in to change notification settings - Fork 80
Optimized POM effects #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Oh wow this looks massive! Thank you so much for your contribution. I'll do some testing and hopefully implement this in the next update if no weird driver issues are found (as we get a lot of those random hardware specific driver issues on pom code :P) |
|
Sry I didn;t expect such a quick response but this PR is still WIP. I'm still working to mitigate some visual changes introduced by this PR. I will speed up so you will be able to test it out in a short time. |
|
Oh that's completely okay you can take as long as you want. I really appreciate your care about this :) |
|
It should be okay now! |
|
Tested on following GPUs:
|
|
Maybe I should make the pallax shadow non-wrapping too. I will try to fix this once I get back to work. And thanks for your time. |
|
Thank you for your care I really appreciate it :) |
|
I made some changes which were intended to fix the issue you mentioned. Could you please take a look? |
|
This is unfortunately just giving me compile errors now. I tested with two different GPU brands in case it was a driver difference issue. Nvidia GPU: AMD GPU: |
|
Sry I just realized that I committed a wrong version. |


Some refactor for better performance. Details can be found in the code comments.
Just tryin' to help out <3