Skip to content

Conversation

@Rabbit0w0
Copy link

Some refactor for better performance. Details can be found in the code comments.

Just tryin' to help out <3

@EminGT
Copy link
Member

EminGT commented Aug 12, 2025

Oh wow this looks massive! Thank you so much for your contribution. I'll do some testing and hopefully implement this in the next update if no weird driver issues are found (as we get a lot of those random hardware specific driver issues on pom code :P)

@Rabbit0w0
Copy link
Author

Sry I didn;t expect such a quick response but this PR is still WIP. I'm still working to mitigate some visual changes introduced by this PR. I will speed up so you will be able to test it out in a short time.

@EminGT
Copy link
Member

EminGT commented Aug 12, 2025

Oh that's completely okay you can take as long as you want. I really appreciate your care about this :)

@Rabbit0w0
Copy link
Author

It should be okay now!

@Rabbit0w0
Copy link
Author

Tested on following GPUs:

  • Vega 8
  • GTX 1060
  • RTX 3060
  • RTX 5070

@EminGT
Copy link
Member

EminGT commented Sep 12, 2025

I'm unfortunately seeing some artifacts. First shot is with this PR

image image

@Rabbit0w0
Copy link
Author

Rabbit0w0 commented Sep 12, 2025

Maybe I should make the pallax shadow non-wrapping too. I will try to fix this once I get back to work. And thanks for your time.

@EminGT
Copy link
Member

EminGT commented Sep 12, 2025

Thank you for your care I really appreciate it :)

@Rabbit0w0
Copy link
Author

I made some changes which were intended to fix the issue you mentioned. Could you please take a look?

@EminGT
Copy link
Member

EminGT commented Dec 12, 2025

This is unfortunately just giving me compile errors now. I tested with two different GPU brands in case it was a driver difference issue.

Nvidia GPU:
0(1083) : error C1503: undefined variable "TileEpsilon"
0(1090) : error C1503: undefined variable "AtlasClamp"
0(1158) : error C1503: undefined variable "TileEpsilon"

AMD GPU:
ERROR: 0:1083: 'TileEpsilon' : no matching overloaded function found
ERROR: 0:1083: '=' : cannot convert from ' const float' to ' temp 2-component vector of float'
ERROR: 0:1083: '' : compilation terminated

@Rabbit0w0
Copy link
Author

Sry I just realized that I committed a wrong version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants