Skip to content

Enable debug info for UWP package #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborziak-ms merged 2 commits into from
May 23, 2025
Merged

Enable debug info for UWP package #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900193f
Add debug info
aborziak-ms May 23, 2025
8130d67
Remove pdb for uap
aborziak-ms May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Lottie-Windows/Lottie-Windows-UwpNET/Lottie-Windows-UwpNET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,11 @@
<PackageTags>UWP Toolkit Windows Animations Lottie XAML</PackageTags>

<DefineConstants>UWPNET</DefineConstants>
<!--
Turn off debugging information for now. It is causing errors with winmd generation because
the build system is creating CommunityToolkit.WinUI.Lottie.compile.pdb but the winmdexp
task expects the name without the "compile." in it.
-->
<DebugType>none</DebugType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.UI.Xaml" Version="2.8.7" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.2.0" />
<PackageReference Include="Win2D.uwp" Version="1.28.2" />
</ItemGroup>

Expand Down
4 changes: 3 additions & 1 deletion build/Lottie-Windows-Uwp.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
<dependencies>
<group targetFramework="net9.0-windows10.0.26100">
<dependency id="Microsoft.UI.Xaml" version="2.8.7" />
<dependency id="Microsoft.Windows.CsWinRT" version="2.2.0" />
<dependency id="Win2D.uwp" version="1.28.2" />
</group>
<group targetFramework="uap10.0.16299">
Expand Down Expand Up @@ -43,12 +42,15 @@
target="lib\net9.0-windows10.0.26100\" />
<file src="pack\lib\net9.0-windows10.0.26100.0\CommunityToolkit.Uwp.Lottie.pri"
target="lib\net9.0-windows10.0.26100\" />
<file src="pack\lib\net9.0-windows10.0.26100.0\CommunityToolkit.Uwp.Lottie.pdb"
target="lib\net9.0-windows10.0.26100\" />

<file src="pack\lib\uap10.0.16299\CommunityToolkit.WinUI.Lottie.winmd"
target="lib\uap10.0.16299\" />
<file src="pack\lib\uap10.0.16299\CommunityToolkit.WinUI.Lottie.pri"
target="lib\uap10.0.16299\" />
<file src="pack\lib\uap10.0.16299\CommunityToolkit.WinUI.Lottie.xml"
target="lib\uap10.0.16299\" />

</files>
</package>
2 changes: 1 addition & 1 deletion version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "8.1.240821-rc.{height}",
"version": "8.2.250523-rc.{height}",
"publicReleaseRefSpec": [
"^refs/heads/main$", // we release out of main
"^refs/heads/dev$", // we release out of dev
Expand Down