Event Metrics Query performance #1227
Conversation
| h('span.u-inlineBlock.u-marginRight--20', [h('strong', `${label}: `), val || '0']) | ||
|
|
||
| const row = (icon, content) => | ||
| const checkedInPercent = (checkedIn = 0 , total = 0) => { |
There was a problem hiding this comment.
Fixes bug with divide by 0 (NaN)...
| , h(`div.fundraiser--${key}`, content) | ||
| const mixin = (content, count) => | ||
| h('section.u-marginBottom--20.u-marginTop--30', [ | ||
| h('h4.u-marginBottom--0.u-paddingX--20', count + ' ' + key.charAt(0).toUpperCase() + key.slice(1) + ' Events') |
There was a problem hiding this comment.
Also, now display the count of events in the header/title:
| @@ -0,0 +1,18 @@ | |||
| class AddIndexesEvents < ActiveRecord::Migration[7.1] | |||
| def change | |||
There was a problem hiding this comment.
Add missing indexes for performance.
| # License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later | ||
| FactoryBot.define do | ||
| factory :ticket do | ||
| event_discount |
There was a problem hiding this comment.
Lots of random factory updates to aid in getting test running.
caseyhelbling
force-pushed
the
feature/clh/increase-db-size-and-indexes
branch
from
a2a90a5 to
3acd120
Compare
|
@caseyhelbling just to be clear, is the goal to recreate the exact behavior of QueryEventMetrics? If so, please move the spec changes into a separate PR so we can verify the specs are accurate. Then follow with this PR so we can see the specs still pass. Otherwise, we're trying to make sure the specs match behavior that we're replacing in the same PR and that's really hard to get right. |
|
| describe "for profile" do | ||
| skip "TODO" | ||
| end |
There was a problem hiding this comment.
Not an issue but a fun little feature of rspec I learned just in the last week.
If you write just describe "for profile" or it without a block, rspec treats it as if you told it to skip.
2 participants
Holy yak shaving...
This started as I was updating the FontAwesome version to 6 so we can get proper brand icons in place (including Bluesky.) That led me to the event listing page, and I noticed the events weren't showing up locally. I was seeing this error consistently:
I debugged a little and learned my local DB was pretty small (so I tuned it up with the docker compose updates.)
That didn't fully solve the issue, but was partially helpful. Next, I decided to rewrite the expensive Qx query using regular Active Record/Arel, attempting to remove several of the joins and improve performance. The result is a query that is significantly more performant (I didn't fully benchmark but would guess 10x faster).
In the process, I didn't see any tests for the legacy_lib / query event metrics query so I wrote one for that as well.
Part of the polish was some light UI updates (slight space between listing items, left justify the heading titles, using h4 for heading title, etc. See picture)...