Skip to content

Conversation

@xsanm
Copy link
Collaborator

@xsanm xsanm commented Dec 4, 2025

Summary: ENG-11547.

Test Plan:

  1. Clean install pods
  2. Run yarn cleaninstall
  3. Run keyserver & web app
  4. Run iOS
  5. Run Android

Reviewers: ashoat

Summary:
[ENG-11547](https://linear.app/comm/issue/ENG-11547/follow-up-remove-olm-c-leftovers).

Test Plan:
1. Clean install pods
2. Run `yarn cleaninstall`
3. Run keyserver & web app
4. Run iOS
5. Run Android

Reviewers: ashoat
@xsanm xsanm requested a review from Ashoat December 4, 2025 16:39
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ashoat
Copy link
Member

Ashoat commented Dec 4, 2025

Might be good to go through git grep -i olm as part of the test plan

@xsanm
Copy link
Collaborator Author

xsanm commented Dec 5, 2025

I ran CI on this in 4eaa727 - it works

Might be good to go through git grep -i olm as part of the test plan

I did that, but we still use olm phrase in many places, like type names, database columns, variables, methods, etc. I reviewed them to make sure anything connected to resources/dependencies is removed

@Ashoat Ashoat marked this pull request as ready for review December 5, 2025 15:37
@Ashoat Ashoat merged commit e0b5341 into master Dec 5, 2025
8 checks passed
@Ashoat Ashoat deleted the remove-olm branch December 5, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants