elad-abutbul #8
Open
elad-abutbul #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 11, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
I checked only the ts file because the logic is the same as in the js file
Looks good overall
store.js
Outdated
| @@ -0,0 +1,77 @@ | |||
| // store.ts | |||
| // Homework - Online Store System | |||
Member
There was a problem hiding this comment.
For the future remove those comments
store.ts
Outdated
| ) /* : add return types */ { | ||
| return []; | ||
| function getAvailableProducts(store: Store): Product[] { | ||
| return store.products.filter((p: Product): boolean => p.inStock); |
Member
There was a problem hiding this comment.
The :boolean is fine but ts can infer its type so you don't really need it in here, just an opinion
store.ts
Outdated
| return []; | ||
| function getProductsByTag(store: Store, tag: string): Product[] { | ||
| return store.products.filter( | ||
| (p: Product): boolean => p.tags.indexOf(tag) !== -1 |
Member
There was a problem hiding this comment.
You could also create another condition:
here is a psudo of the condition:
product => product.tags.includes(tag)
But both are fine
| function getCartTotalInStock(store: Store, cart: number[]): number { | ||
| return getCartProducts(store, cart) | ||
| .filter((p: Product): boolean => p.inStock) | ||
| .reduce( |
store.js
Outdated
| // ------------------------------------ | ||
| // Store data (5 products) | ||
| // ------------------------------------ | ||
| var store = { |
Member
There was a problem hiding this comment.
You can change this file into a .ts file and give the store interface and create one
Tamir198
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.