Beny #4
Open
Beny #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 11, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Hey so 2 main things that i see repeating:
No console logs
You dont have to booleanVariable === true inside a condition, if(booleanVariable) is eonugh
store.ts
Outdated
| ) /* : add return types */ { | ||
| return []; | ||
| function getAvailableProducts(store: Store): Product[] { | ||
| return store.products.filter((product) => product.inStock === true); |
Member
There was a problem hiding this comment.
You could do something like this :
return store.products.filter((product)=>product.inStock);Because the inStock in a boolean
store.ts
Outdated
| function getAvailableProducts(store: Store): Product[] { | ||
| return store.products.filter((product) => product.inStock === true); | ||
| } | ||
| console.log("getAvailableProducts:", getAvailableProducts(store)); |
Member
There was a problem hiding this comment.
When we submit prs in the industry we remove the console.logs
store.ts
Outdated
| (p) => p.price >= minPrice && p.price <= maxPrice | ||
| ); | ||
| } | ||
| console.log("getProductsInPriceRange", getProductsInPriceRange(store, 10, 100)); |
Member
There was a problem hiding this comment.
Save 10 and 100 inside variables, otherwise those are just magic numbers and we dont really have a context for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.