Finish Festival Lineup assignment #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 16, 2025
| } | ||
|
|
||
| let ticketsStatusText:string; | ||
| if(ticketsLeft===0) |
Member
There was a problem hiding this comment.
Extract this into constant variable
|
|
||
| let ticketsStatusText:string; | ||
| if(ticketsLeft===0) | ||
| ticketsStatusText="SOLD OUT"; |
Member
There was a problem hiding this comment.
Same for the hardcoded text (better sit inside constant file)
When we have magic numbers like this in the code (magic number is any number hardcoded inside the code) its very confusing
| // 1–30 → "Last tickets – hurry up!" | ||
| // >30 → "Tickets available" | ||
| let interestedText:string; | ||
| if(isInterested) |
Member
There was a problem hiding this comment.
You can do interestedText = condition ? "first text" : "second text"
| {/* TODO - shows.map((show)=>{ return <ShowCard id={show.id} .../> })*/} | ||
| {shows.map((show) => { | ||
| return ( | ||
| <ShowCard |
Member
There was a problem hiding this comment.
Will this work? :
{shows.map((show) => (
<ShowCard key={show.id} {...show} />
))}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.