Skip to content

Conversation

@Ashjz
Copy link

@Ashjz Ashjz commented Sep 10, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

same page on May cohort

Questions

no

@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 3f3dab9
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68c2033a92fe2d0008b0c487
😎 Deploy Preview https://deploy-preview-775--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ashjz Ashjz added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 10, 2025
@jenny-alexander jenny-alexander self-requested a review September 11, 2025 03:43
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 11, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Sep 15, 2025

@Ashjz

Why did you close this reviewed PR? Different reviewers, having different specialties, may focus on different things which you could improve. Can you address @LonMcGregor comments in this PR (since you have already closed the other PR) in addition to addressing the comments given by @jenny-alexander?

Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on working through the requirements! While the CSS and HTML file are done well, I would spend some time reviewing the layout requirements defined in the wireframe.

There are a few changes needed:

  • Can you review the wireframe more carefully? Notice how the article title, summary and button are aligned to the left. Can you modify your application to look like this?
Image
  • The image for each article should span the width of the container it's contained within. Right now, your images are center-aligned.
  • The font for 'README' is slightly larger than the page title font. The page title font should be the largest on the page.
  • Can you shorten the Page summary ('Take a look at the answers to some questions...')? Right now, it's a little bit too long and doesn't match the wireframe requirements.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this change from the PR? We want to stick to the exercise requirements and only modify files when directed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your styling is done well. In the future, you might want to consider adding custom properties to the :root{} selector. Commonly used colors, padding, styles, etc can be added to root for easier maintenance in the future since the developer doesn't have to search through the CSS file to find where a common style is applied.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 15, 2025
@Ashjz
Copy link
Author

Ashjz commented Sep 20, 2025

@Ashjz

Why did you close this reviewed PR? Different reviewers, having different specialties, may focus on different things which you could improve. Can you address @LonMcGregor comments in this PR (since you have already closed the other PR) in addition to addressing the comments given by @jenny-alexander?

because it was the wrong pr actually

@cjyuan
Copy link
Contributor

cjyuan commented Sep 20, 2025

@Ashjz
Why did you close this reviewed PR? Different reviewers, having different specialties, may focus on different things which you could improve. Can you address @LonMcGregor comments in this PR (since you have already closed the other PR) in addition to addressing the comments given by @jenny-alexander?

because it was the wrong pr actually

What do you mean by "wrong pr". That PR and this PR shared the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants