-
-
Notifications
You must be signed in to change notification settings - Fork 357
London | ITP-Sep-2025 | Mohammad_Jafarzadeh | Sprint 1 | Wireframe #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f7e0a26.
…png, and readme.png.webp
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Why did you close this reviewed PR? Different reviewers, having different specialties, may focus on different things which you could improve. Can you address @LonMcGregor comments in this PR (since you have already closed the other PR) in addition to addressing the comments given by @jenny-alexander? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on working through the requirements! While the CSS and HTML file are done well, I would spend some time reviewing the layout requirements defined in the wireframe.
There are a few changes needed:
- Can you review the wireframe more carefully? Notice how the article title, summary and button are aligned to the left. Can you modify your application to look like this?
- The image for each article should span the width of the container it's contained within. Right now, your images are center-aligned.
- The font for 'README' is slightly larger than the page title font. The page title font should be the largest on the page.
- Can you shorten the Page summary ('Take a look at the answers to some questions...')? Right now, it's a little bit too long and doesn't match the wireframe requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this change from the PR? We want to stick to the exercise requirements and only modify files when directed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your styling is done well. In the future, you might want to consider adding custom properties to the :root{} selector. Commonly used colors, padding, styles, etc can be added to root for easier maintenance in the future since the developer doesn't have to search through the CSS file to find where a common style is applied.
because it was the wrong pr actually |
What do you mean by "wrong pr". That PR and this PR shared the same branch. |

Learners, PR Template
Self checklist
Changelist
same page on May cohort
Questions
no