West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 2 | Form control #742
Conversation
…input to ensure the user can't submit names with only spaces.
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
ahmadehsas
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
ahmadehsas
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
18 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
In the pull requests "Changelist" section, it is expected that you give a brief explanation of what major changes you made. If you have no questions you can remove that section.
Good to see you have experimented with different input types!
Form-Controls/index.html
Outdated
| this will also help you fill in your PR message later--> | ||
| <!--Name--> | ||
| <label for="name">Full name:</label> | ||
| <input type="text" id="name" name="name" required pattern=".*\S.*"> |
There was a problem hiding this comment.
Can you find where in the readme there is a spec for how to validate names. Does your solution match that?
There was a problem hiding this comment.
In line 21, there is a spec for how to validate names.
In index.html, I also validate the name inside the input. This means the field can not be left empty.
If the user tries to submit the form without typing anything, the browser will show a warning like: "Please, fill out this field".
There was a problem hiding this comment.
The readme says
I require a valid name. I have defined a valid name as a text string of two characters or more.
Does your implementation match this validation?
There was a problem hiding this comment.
I validated the name as a text string of two or more characters. Now my implementation matches this validation.
LonMcGregor
added
Reviewed
ahmadehsas
added
Needs Review
LonMcGregor
added
Reviewed
ahmadehsas
added
Needs Review
|
The implementation is a bit closer now - I see you're using A-Za-z in your regex. What would happen if someone had a foreign name with a character like é in their name. Does it still work? |
LonMcGregor
added
Reviewed
ahmadehsas
added
Needs Review
|
Great! you're done with this sprint task now! |
LonMcGregor
added
Complete
3 participants
-->
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR:
I have completed all the mandatory tasks.using HTML and CSS, I have added Title, labels for this form.
At the end of form I have added Submit button for submitting the form after completing the form.