Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889

Fares-Bakhet · 2025-11-26T15:37:41Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Editing the JS and HTML files to create a quote generator app.

Questions

No questions.

cjyuan

Can you revert all unrelated changes made on this branch to keep it clean?

cjyuan · 2025-11-29T11:08:56Z

Sprint-3/quote-generator/index.html

+    <h1>Quote Generator App</h1>
+    <div id="quote-container">
+  <p id="quote-text"></p>
+  <p id="quote-author"></p>
+  <button id="new-quote-button">New Quote</button>
+    </div>


Indentation is off.

@cjyuan, I have reverted all the changes I have made.

cjyuan · 2025-11-29T11:11:27Z

Sprint-3/quote-generator/quotes.js

+function showRandomQuote() {
+  const randomQuote = pickFromArray(quotes);
+  const quoteText = document.getElementById("quote-text");
+  const quoteAuthor = document.getElementById("quote-author");
+
+  quoteText.innerText = randomQuote.quote;
+  quoteAuthor.innerText = `— ${randomQuote.author}`;
+}
+
+window.onload = showRandomQuote;
+
+document.getElementById("new-quote-button").addEventListener("click", showRandomQuote);
+


We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?

@cjyuan, I have looked up and learn the lesson.

This reverts commit b6b3f4a.

This reverts commit 7221a18.

This reverts commit 6d8e6c5.

This reverts commit f5a92f8.

This reverts commit d5a5bcd.

This reverts commit 81769d1.

This reverts commit 1babce8.

This reverts commit ed3cee8.

This reverts commit 63b7d45.

cjyuan

Branch is still not clean; it contains some unmodified files in the Sprint-2 folder. Can you make this branch clean?

cjyuan · 2025-12-01T18:22:29Z

Sprint-3/quote-generator/index.html

  <body>
+    <main>
+      <section></section>
    <h1>hello there</h1>
    <p id="quote"></p>
    <p id="author"></p>
    <button type="button" id="new-quote">New quote</button>
+      </section>
+    </main>
+    <script defer src="quotes.js"></script>
  </body>


Indentation is still off and there seems to be some error in the HTML code.

This reverts commit ab693e3.

This reverts commit 26642e0.

This reverts commit aeabc14.

Fares-Bakhet · 2025-12-02T14:29:28Z

@cjyuan, I made a big mess, but I hope it's cleaned now.

cjyuan

Code is good.
There are still two unrelated changed files in Sprint-2/implement. Can you revert them?

Fares-Bakhet · 2025-12-03T10:43:32Z

Code is good.

There are still two unrelated changed files in Sprint-2/implement. Can you revert them?

@cjyuan. When reverting Sprint-2/implement files, it shows that the reverting is in progress, but nothing actually changes.
It feels like it's stuck in there.

updates:
I believe these two were the problem
19ca88d Adding tests in contains.test.js file
7105146 Implement a function in contains.js file

I have managed to revert them.

This reverts commit 7105146.

This reverts commit 19ca88d.

cjyuan · 2025-12-03T20:39:53Z

You did it! All good now!

Fares Bakhet added 18 commits November 14, 2025 12:05

Fix the bug in address.js file

aeabc14

Fix the bug in author.js file

26642e0

Fix the bug in recipe.js file

ab693e3

Implement a function in contains.js file

7105146

Adding tests in contains.test.js file

19ca88d

Implementing a function in lookup.js file

63b7d45

Adding tests in lookup.test.js file

ed3cee8

Fix the implement function in querysrting.js file

1babce8

Adding tests in querystring.test.js file

fd422f1

Fix the implement function in tally.js file

9279df9

Adding tests in tally.test.js file

1c6ccc3

Answering questions and fix the implemention and adding tests

8465e56

Adding implementation and test to the file

81769d1

Answering questions

d5a5bcd

Answering till.js questions

f5a92f8

Implementing a alarmclock function

6d8e6c5

Editing file index.html

7221a18

Editing file index.html and quotes.js files

b6b3f4a

Fares-Bakhet added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 26, 2025

cjyuan reviewed Nov 29, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 29, 2025

Fares-Bakhet added 6 commits December 1, 2025 15:00

Revert "Editing file index.html and quotes.js files"

70e0519

This reverts commit b6b3f4a.

Revert "Editing file index.html"

5ad1f39

This reverts commit 7221a18.

Revert "Implementing a alarmclock function"

413577b

This reverts commit 6d8e6c5.

Revert "Answering till.js questions"

67ecaaa

This reverts commit f5a92f8.

Revert "Answering questions"

0939554

This reverts commit d5a5bcd.

Revert "Adding implementation and test to the file"

0d54919

This reverts commit 81769d1.

Fares-Bakhet added 4 commits December 1, 2025 15:02

Revert "Fix the implement function in querysrting.js file"

62ef964

This reverts commit 1babce8.

Revert "Adding tests in lookup.test.js file"

5377515

This reverts commit ed3cee8.

Revert "Implementing a function in lookup.js file"

9610268

This reverts commit 63b7d45.

Fix quotes generator app

a657abb

Fares-Bakhet added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025

cjyuan reviewed Dec 1, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 1, 2025

Fares-Bakhet added 4 commits December 2, 2025 13:32

Fix HTML file

1dd4be9

Revert "Fix the bug in recipe.js file"

c9868e3

This reverts commit ab693e3.

Revert "Fix the bug in author.js file"

7f44363

This reverts commit 26642e0.

Revert "Fix the bug in address.js file"

f5893f0

This reverts commit aeabc14.

fix HTML file

b415c8c

Fares-Bakhet added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 2, 2025

cjyuan reviewed Dec 2, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 2, 2025

Fares-Bakhet added 2 commits December 3, 2025 10:46

Revert "Implement a function in contains.js file"

aa4c140

This reverts commit 7105146.

Revert "Adding tests in contains.test.js file"

2e03c03

This reverts commit 19ca88d.

Fares-Bakhet added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 3, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025

Fares-Bakhet mentioned this pull request Dec 10, 2025

25-ITP-SEP | Data Groups | Fares Bakhet Fares-Bakhet/My-Coursework-Planner#69

Open

illicitonion closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889

Uh oh!

Fares-Bakhet commented Nov 26, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Nov 29, 2025

Uh oh!

Fares-Bakhet Dec 1, 2025

Uh oh!

cjyuan Nov 29, 2025

Uh oh!

Fares-Bakhet Dec 1, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Dec 1, 2025

Uh oh!

Fares-Bakhet commented Dec 2, 2025

Uh oh!

cjyuan left a comment

Uh oh!

Fares-Bakhet commented Dec 3, 2025 •

edited

Loading

Uh oh!

cjyuan commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 3 | Quote Generator App #889

Uh oh!

Conversation

Fares-Bakhet commented Nov 26, 2025

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Fares-Bakhet Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Fares-Bakhet Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Fares-Bakhet commented Dec 2, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Fares-Bakhet commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fares-Bakhet commented Dec 3, 2025 •

edited

Loading